1. 01 Feb, 2017 3 commits
  2. 08 Nov, 2016 4 commits
  3. 11 Apr, 2016 7 commits
  4. 07 Jan, 2016 8 commits
  5. 09 Mar, 2015 1 commit
  6. 20 Nov, 2014 15 commits
  7. 28 May, 2014 2 commits
    • Finn Thain's avatar
      scsi/NCR5380: fix and standardize NDEBUG macros · 9829e528
      Finn Thain authored
      All three NCR5380 core driver implementations share the same NCR5380.h
      header file so they need to agree on certain macro definitions.
      
      The flag bit used by the NDEBUG_MERGING macro in atari_NCR5380 and
      sun3_NCR5380 collides with the bit used by NDEBUG_LISTS.
      
      Moreover, NDEBUG_ABORT appears in NCR5380.c so it should be defined in
      NCR5380.h rather than in each of the many drivers using that core.
      
      An undefined NDEBUG_ABORT macro caused compiler errors and led to dodgy
      workarounds in the core driver that can now be removed.
      (See commits f566a576 and
      185a7a1c.)
      
      Move all of the NDEBUG_ABORT, NDEBUG_TAGS and NDEBUG_MERGING macro
      definitions into NCR5380.h where all the other NDEBUG macros live.
      
      Also, incorrect "#ifdef NDEBUG" becomes "#if NDEBUG" to fix the warning:
      drivers/scsi/mac_scsi.c: At top level:
      drivers/scsi/NCR5380.c:418: warning: 'NCR5380_print' defined but not used
      drivers/scsi/NCR5380.c:459: warning: 'NCR5380_print_phase' defined but not used
      
      The debugging code is now enabled when NDEBUG != 0.
      Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
      Acked-by: default avatarSam Creasey <sammy@sammy.net>
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      9829e528
    • Finn Thain's avatar
      scsi/NCR5380: adopt dprintk() · d65e634a
      Finn Thain authored
      All NCR5380 drivers already include the NCR5380.h header. Better to
      adopt those macros rather than have three variations on them.
      
      Moreover, the macros in NCR5380.h are preferable because the atari_NCR5380
      and sun3_NCR5380 versions are inflexible. For example, they can't accomodate
      dprintk(NDEBUG_MAIN | NDEBUG_QUEUES, ...)
      
      Replace the *_PRINTK macros from atari_NCR5380.h and sun3_NCR5380.h with
      the equivalent macros from NCR5380.h.
      Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
      Acked-by: default avatarSam Creasey <sammy@sammy.net>
      Acked-by: default avatarMichael Schmitz <schmitz@debian.org>
      Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
      d65e634a