1. 06 May, 2010 15 commits
  2. 07 Apr, 2010 1 commit
    • Wolfram Sang's avatar
      device_attributes: add sysfs_attr_init() for dynamic attributes · 12765517
      Wolfram Sang authored
      Made necessary by 6992f533 ("sysfs: Use
      one lockdep class per sysfs attribute").
      
      Prevents further "key xxx not in .data" bug-reports.  Although some
      attributes could probably be converted to static ones, this is left for
      people having hardware to test.
      
      Found by this semantic patch:
      
      @ init @
      type T;
      identifier A;
      @@
      
              T {
                      ...
                      struct device_attribute A;
                      ...
              };
      
      @ main extends init @
      expression E;
      statement S;
      identifier err;
      T *name;
      @@
      
              ... when != sysfs_attr_init(&name->A.attr);
      (
      +       sysfs_attr_init(&name->A.attr);
              if (device_create_file(E, &name->A))
                      S
      |
      +       sysfs_attr_init(&name->A.attr);
              err = device_create_file(E, &name->A);
      )
      
      While reviewing, I put the initialization to apropriate places.
      Signed-off-by: default avatarWolfram Sang <w.sang@pengutronix.de>
      Cc: Eric W. Biederman <ebiederm@xmission.com>
      Cc: Greg KH <gregkh@suse.de>
      Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
      Cc: Grant Likely <grant.likely@secretlab.ca>
      Cc: Mike Isely <isely@pobox.com>
      Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
      Cc: Sujith Thomas <sujith.thomas@intel.com>
      Cc: Matthew Garrett <mjg@redhat.com>
      Cc: Len Brown <len.brown@intel.com>
      Cc: Krzysztof Helt <krzysztof.h1@wp.pl>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      12765517
  3. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  4. 09 Mar, 2010 1 commit
  5. 08 Mar, 2010 1 commit
  6. 02 Mar, 2010 1 commit
  7. 27 Feb, 2010 1 commit
    • Way Chuang Ang's avatar
      dvb-core: Fix DoS bug in ULE decapsulation code that can be triggered by an invalid Payload Pointer · 29e1fa35
      Way Chuang Ang authored
      ULE (Unidirectional Lightweight Encapsulation RFC 4326) decapsulation
      has a bug that causes endless loop when Payload Pointer of MPEG2-TS
      frame is 182 or 183.  Anyone who sends malicious MPEG2-TS frame will
      cause the receiver of ULE SNDU to go into endless loop.
      
      This patch was generated and tested against linux-2.6.32.9 and should
      apply cleanly to linux-2.6.33 as well because there was only one typo
      fix to dvb_net.c since v2.6.32.
      
      This bug was brought to you by modern day Santa Claus who decided to
      shower the satellite dish at Keio University with heavy snow causing
      huge burst of errors.  We, receiver end, received Santa Claus's gift in
      the form of kernel bug.
      
      Care has been taken not to introduce more bug by fixing this bug, but
      please scrutinize the code for I always produces buggy code.
      Signed-off-by: Way Chuang Ang's avatarAng Way Chuang <wcang79@gmail.com>
      Acked-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
      Cc: stable@kernel.org
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      29e1fa35
  8. 26 Feb, 2010 19 commits