1. 31 Oct, 2018 1 commit
  2. 20 Jul, 2017 1 commit
    • Ingo Molnar's avatar
      x86/boot: Fix memremap() related build failure · 693bf0aa
      Ingo Molnar authored
      The following commit:
      
        5997efb9 ("x86/boot: Use memremap() to map the MPF and MPC data")
      
      causes new build failures on certain randconfigs:
      
        drivers/sfi/sfi_core.c: In function ‘sfi_map_memory’:
        drivers/sfi/sfi_core.c:104:10: error: implicit declaration of function ‘memremap’ [-Werror=implicit-function-declaration]
        drivers/sfi/sfi_core.c:104:31: error: ‘MEMREMAP_WB’ undeclared (first use in this function)
      
      This is a case of parasitic header dependencies: the sfi_core.c file indirectly
      includes <linux/io.h> for typical - but not all configs.
      
      Including <linux/io.h> explicitly solves the build failure.
      
      Cc: Linus Torvalds <torvalds@linux-foundation.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Thomas Gleixner <tglx@linutronix.de>
      Cc: arnd@arndb.de
      Cc: aryabinin@virtuozzo.com
      Cc: bp@alien8.de
      Cc: bp@suse.de
      Cc: brijesh.singh@amd.com
      Cc: corbet@lwn.net
      Cc: dvyukov@google.com
      Cc: dyoung@redhat.com
      Cc: glider@google.com
      Cc: konrad.wilk@oracle.com
      Cc: linux-tip-commits@vger.kernel.org
      Cc: luto@kernel.org
      Cc: lwoodman@redhat.com
      Cc: matt@codeblueprint.co.uk
      Cc: mst@redhat.com
      Cc: pbonzini@redhat.com
      Cc: riel@redhat.com
      Cc: rkrcmar@redhat.com
      Cc: thomas.lendacky@amd.com
      Cc: toshi.kani@hpe.com
      Link: http://lkml.kernel.org/r/20170720092307.6xslahuaclmsiffe@gmail.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
      693bf0aa
  3. 18 Jul, 2017 1 commit
    • Tom Lendacky's avatar
      x86, mpparse, x86/acpi, x86/PCI, x86/dmi, SFI: Use memremap() for RAM mappings · f7750a79
      Tom Lendacky authored
      The ioremap() function is intended for mapping MMIO. For RAM, the
      memremap() function should be used. Convert calls from ioremap() to
      memremap() when re-mapping RAM.
      
      This will be used later by SME to control how the encryption mask is
      applied to memory mappings, with certain memory locations being mapped
      decrypted vs encrypted.
      Signed-off-by: default avatarTom Lendacky <thomas.lendacky@amd.com>
      Reviewed-by: default avatarThomas Gleixner <tglx@linutronix.de>
      Reviewed-by: default avatarBorislav Petkov <bp@suse.de>
      Cc: Alexander Potapenko <glider@google.com>
      Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
      Cc: Andy Lutomirski <luto@kernel.org>
      Cc: Arnd Bergmann <arnd@arndb.de>
      Cc: Borislav Petkov <bp@alien8.de>
      Cc: Brijesh Singh <brijesh.singh@amd.com>
      Cc: Dave Young <dyoung@redhat.com>
      Cc: Dmitry Vyukov <dvyukov@google.com>
      Cc: Jonathan Corbet <corbet@lwn.net>
      Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
      Cc: Larry Woodman <lwoodman@redhat.com>
      Cc: Linus Torvalds <torvalds@linux-foundation.org>
      Cc: Matt Fleming <matt@codeblueprint.co.uk>
      Cc: Michael S. Tsirkin <mst@redhat.com>
      Cc: Paolo Bonzini <pbonzini@redhat.com>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Radim Krčmář <rkrcmar@redhat.com>
      Cc: Rik van Riel <riel@redhat.com>
      Cc: Toshimitsu Kani <toshi.kani@hpe.com>
      Cc: kasan-dev@googlegroups.com
      Cc: kvm@vger.kernel.org
      Cc: linux-arch@vger.kernel.org
      Cc: linux-doc@vger.kernel.org
      Cc: linux-efi@vger.kernel.org
      Cc: linux-mm@kvack.org
      Link: http://lkml.kernel.org/r/b13fccb9abbd547a7eef7b1fdfc223431b211c88.1500319216.git.thomas.lendacky@amd.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
      f7750a79
  4. 03 Dec, 2014 1 commit
  5. 07 Dec, 2013 2 commits
    • Lv Zheng's avatar
      SFI / ACPI: Fix warnings reported during builds with W=1 · c099eacb
      Lv Zheng authored
      The following warnings can be seen in W=1 builds, because the original
      sfi_acpi.[ch] header inclusions are incorrect:
      
      include/linux/sfi_acpi.h:72:2: error: implicit declaration of function 'acpi_table_parse' [-Werror=implicit-function-declaration]
      drivers/sfi/sfi_acpi.c:154:5: warning: no previous prototype for 'sfi_acpi_table_parse' [-Wmissing-prototypes]
      
      Fix linux/sfi_acpi.h and modify drivers/sfi/sfi_acpi.c accordingly.
      Reported-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
      Signed-off-by: default avatarLv Zheng <lv.zheng@intel.com>
      [rjw: Subject and changelog]
      Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
      c099eacb
    • Lv Zheng's avatar
      ACPI: Clean up inclusions of ACPI header files · 8b48463f
      Lv Zheng authored
      Replace direct inclusions of <acpi/acpi.h>, <acpi/acpi_bus.h> and
      <acpi/acpi_drivers.h>, which are incorrect, with <linux/acpi.h>
      inclusions and remove some inclusions of those files that aren't
      necessary.
      
      First of all, <acpi/acpi.h>, <acpi/acpi_bus.h> and <acpi/acpi_drivers.h>
      should not be included directly from any files that are built for
      CONFIG_ACPI unset, because that generally leads to build warnings about
      undefined symbols in !CONFIG_ACPI builds.  For CONFIG_ACPI set,
      <linux/acpi.h> includes those files and for CONFIG_ACPI unset it
      provides stub ACPI symbols to be used in that case.
      
      Second, there are ordering dependencies between those files that always
      have to be met.  Namely, it is required that <acpi/acpi_bus.h> be included
      prior to <acpi/acpi_drivers.h> so that the acpi_pci_root declarations the
      latter depends on are always there.  And <acpi/acpi.h> which provides
      basic ACPICA type declarations should always be included prior to any other
      ACPI headers in CONFIG_ACPI builds.  That also is taken care of including
      <linux/acpi.h> as appropriate.
      Signed-off-by: default avatarLv Zheng <lv.zheng@intel.com>
      Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
      Cc: Matthew Garrett <mjg59@srcf.ucam.org>
      Cc: Tony Luck <tony.luck@intel.com>
      Cc: "H. Peter Anvin" <hpa@zytor.com>
      Acked-by: Bjorn Helgaas <bhelgaas@google.com> (drivers/pci stuff)
      Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> (Xen stuff)
      Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
      8b48463f
  6. 31 Oct, 2011 1 commit
    • Randy Dunlap's avatar
      drivers/sfi: sfi_acpi.c needs sysfs.h · d2185c44
      Randy Dunlap authored
      sfi_acpi.c needs to include linux/sysfs.h for data types.
      
      drivers/sfi/sfi_core.h:66: error: field 'attr' has incomplete type
      drivers/sfi/sfi_acpi.c:179: warning: 'struct kobject' declared inside parameter list
      drivers/sfi/sfi_acpi.c:179: warning: its scope is only this definition or declaration, which is probably not what you want
      drivers/sfi/sfi_acpi.c:182: warning: type defaults to 'int' in declaration of '__mptr'
      drivers/sfi/sfi_acpi.c:182: warning: initialization from incompatible pointer type
      Signed-off-by: default avatarRandy Dunlap <rdunlap@xenotime.net>
      Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
      d2185c44
  7. 31 Mar, 2011 1 commit
  8. 12 Jan, 2011 1 commit
  9. 01 Jun, 2010 1 commit
  10. 27 May, 2010 1 commit
  11. 25 May, 2010 1 commit
    • Feng Tang's avatar
      SFI: add support for v0.81 spec · 5487ab4a
      Feng Tang authored
      There are 2 major changes from v0.81 to v0.7:
      1. Consolidating the SPIB/I2CB tables into a new DEVS table,
         which is more expandable and can support other bus types
         than spi/i2c.
      2. Creating a new GPIO table, which list all the GPIO pins
         used in the platform.
      
      However, to avoid breaking current platforms who use SFI v0.7
      version firmware, the definitions for SPIB/I2CB will still
      be kept for a while
      Signed-off-by: default avatarFeng Tang <feng.tang@intel.com>
      Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      5487ab4a
  12. 03 Oct, 2009 2 commits
    • Arjan van de Ven's avatar
      SFI: remove __init from sfi_verify_table · 011a606d
      Arjan van de Ven authored
      sfi_verify_table() is called at runtime, and thus cannot be __init
      Signed-off-by: default avatarArjan van de Ven <arjan@linux.intel.com>
      Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      011a606d
    • Rakib Mullick's avatar
      SFI: fix section mismatch warnings in sfi_core.c · 01674da6
      Rakib Mullick authored
      The function sfi_map_memory/sfi_unmap_memory uses
      early_ioremap/early_iounmap respectively, which refers to a __init
      function.  And function sfi_check_table also refers to a __init function
      sfi_verify_table.  Since the references are valid, so use __ref to get rid
      of the warnings.
      
       We were warned by the following warnings:
      
        LD      vmlinux.o
        MODPOST vmlinux.o
      WARNING: vmlinux.o(.text+0xb6ba3a): Section mismatch in reference from
      the function sfi_map_memory() to the function
      .init.text:early_ioremap()
      The function sfi_map_memory() references
      the function __init early_ioremap().
      This is often because sfi_map_memory lacks a __init
      annotation or the annotation of early_ioremap is wrong.
      
      WARNING: vmlinux.o(.text+0xb6bab6): Section mismatch in reference from
      the function sfi_unmap_memory() to the function
      .init.text:early_iounmap()
      The function sfi_unmap_memory() references
      the function __init early_iounmap().
      This is often because sfi_unmap_memory lacks a __init
      annotation or the annotation of early_iounmap is wrong.
      
      WARNING: vmlinux.o(.text+0xb6be30): Section mismatch in reference from
      the function sfi_check_table() to the function
      .init.text:sfi_verify_table()
      The function sfi_check_table() references
      the function __init sfi_verify_table().
      This is often because sfi_check_table lacks a __init
      annotation or the annotation of sfi_verify_table is wrong.
      Signed-off-by: default avatarRakib Mullick <rakib.mullick@gmail.com>
      Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: default avatarLen Brown <len.brown@intel.com>
      01674da6
  13. 15 Sep, 2009 1 commit
  14. 28 Aug, 2009 3 commits