1. 31 Jul, 2013 1 commit
    • Benjamin Tissoires's avatar
      HID: trivial devm conversion for special hid drivers · abf832bf
      Benjamin Tissoires authored
      It is safe to use devres allocation within the hid subsystem:
      - the devres release is called _after_ the call to .remove(), meaning
        that no freed pointers will exists while removing the device
      - if a .probe() fails, devres releases all the allocated ressources
        before going to the next driver: there will not be ghost ressources
        attached to a hid device if several drivers are probed.
      
      Given that, we can clean up a little some of the HID drivers. These ones
      are trivial:
      - there is only one kzalloc in the driver
      - the .remove() callback contains only one kfree on top of hid_hw_stop()
      - the error path in the probe is easy enough to be manually checked
      Signed-off-by: default avatarBenjamin Tissoires <benjamin.tissoires@redhat.com>
      Reviewed-by: Andy Shevchenko's avatarAndy Shevchenko <andy.shevchenko@gmail.com>
      Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
      abf832bf
  2. 03 Jan, 2013 1 commit
  3. 05 Sep, 2012 1 commit
    • Jiri Kosina's avatar
      HID: remove Paul Walmsley's copyright from places where it shouldn't be · 2f43f874
      Jiri Kosina authored
      Paul Walmsley has implemented dynamic quirk handling back in 2007 through
      commits:
      
      2eb5dc30 ("USB HID: encapsulate quirk handling into hid-quirks.c")
      8222fbe6 ("USB HID: clarify static quirk handling as squirks")
      8cef9082 ("USB HID: add support for dynamically-created quirks")
      876b9276 ("USB HID: add 'quirks' module parameter")
      
      and as such, his copyright rightly belongs to
      drivers/hid/usbhid/hid-quirks.c file.
      
      However when generic HID code has been converted to bus and individual
      quirks separated out to individual drivers on the bus, the copyright has
      been blindly transfered into all the tiny drivers, which actually don't
      contain any of Pauls' copyrighted code.
      
      Remove the copyright from those sub-drivers.
      Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
      Acked-by: default avatarPaul Walmsley <paul@pwsan.com>
      2f43f874
  4. 10 Dec, 2010 1 commit
    • Joe Perches's avatar
      HID: Add and use hid_<level>: dev_<level> equivalents · 4291ee30
      Joe Perches authored
      Neaten current uses of dev_<level> by adding and using
      hid specific hid_<level> macros.
      
      Convert existing uses of dev_<level> uses to hid_<level>.
      Convert hid-pidff printk uses to hid_<level>.
      
      Remove err_hid and use hid_err instead.
      
      Add missing newlines to logging messages where necessary.
      Coalesce format strings.
      
      Add and use pr_fmt(fmt) KBUILD_MODNAME ": " fmt
      
      Other miscellaneous changes:
      
      Add const struct hid_device * argument to hid-core functions
      extract() and implement() so hid_<level> can be used by them.
      Fix bad indentation in hid-core hid_input_field function
      that calls extract() function above.
      Signed-off-by: default avatarJoe Perches <joe@perches.com>
      Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
      4291ee30
  5. 17 Sep, 2010 1 commit
  6. 30 Mar, 2010 1 commit
    • Tejun Heo's avatar
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo authored
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      Guess-its-ok-by: default avatarChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  7. 22 Jul, 2009 1 commit
  8. 30 Mar, 2009 1 commit
    • Jiri Slaby's avatar
      HID: remove compat stuff · afa5eb7c
      Jiri Slaby authored
      This removal was scheduled and there is no problem with later
      distros to adapt for the new bus, thanks to aliases.
      
      module-init-tools map files are deprecated nowadays, so that
      the patch which introduced hid ones into the m-i-t won't be
      accepted and hence there is no reason for leaving compat stuff in.
      Signed-off-by: default avatarJiri Slaby <jirislaby@gmail.com>
      Cc: Jiri Kosina <jkosina@suse.cz>
      Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
      afa5eb7c
  9. 14 Oct, 2008 2 commits