Commit f904f582 authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Ingo Molnar

sched/debug: Fix preempt_disable_ip recording for preempt_disable()

The preempt_disable() invokes preempt_count_add() which saves the caller
in ->preempt_disable_ip. It uses CALLER_ADDR1 which does not look for
its caller but for the parent of the caller. Which means we get the correct
caller for something like spin_lock() unless the architectures inlines
those invocations. It is always wrong for preempt_disable() or

This patch makes the function get_lock_parent_ip() which tries
CALLER_ADDR0,1,2 if the former is a locking function.
This seems to record the preempt_disable() caller properly for
preempt_disable() itself as well as for get_cpu_var() or

Steven asked for the get_parent_ip() -> get_lock_parent_ip() rename.
Signed-off-by: default avatarSebastian Andrzej Siewior <>
Signed-off-by: default avatarPeter Zijlstra (Intel) <>
Cc: Linus Torvalds <>
Cc: Mike Galbraith <>
Cc: Peter Zijlstra <>
Cc: Steven Rostedt <>
Cc: Thomas Gleixner <>
Link: default avatarIngo Molnar <>
parent ff9a9b4c
......@@ -713,6 +713,18 @@ static inline void __ftrace_enabled_restore(int enabled)
#define CALLER_ADDR5 ((unsigned long)ftrace_return_address(5))
#define CALLER_ADDR6 ((unsigned long)ftrace_return_address(6))
static inline unsigned long get_lock_parent_ip(void)
unsigned long addr = CALLER_ADDR0;
if (!in_lock_functions(addr))
return addr;
addr = CALLER_ADDR1;
if (!in_lock_functions(addr))
return addr;
return CALLER_ADDR2;
extern void time_hardirqs_on(unsigned long a0, unsigned long a1);
extern void time_hardirqs_off(unsigned long a0, unsigned long a1);
......@@ -182,8 +182,6 @@ extern void update_cpu_load_nohz(int active);
static inline void update_cpu_load_nohz(int active) { }
extern unsigned long get_parent_ip(unsigned long addr);
extern void dump_cpu_task(int cpu);
struct seq_file;
......@@ -2946,16 +2946,6 @@ u64 scheduler_tick_max_deferment(void)
notrace unsigned long get_parent_ip(unsigned long addr)
if (in_lock_functions(addr)) {
addr = CALLER_ADDR2;
if (in_lock_functions(addr))
addr = CALLER_ADDR3;
return addr;
#if defined(CONFIG_PREEMPT) && (defined(CONFIG_DEBUG_PREEMPT) || \
......@@ -2977,7 +2967,7 @@ void preempt_count_add(int val)
if (preempt_count() == val) {
unsigned long ip = get_parent_ip(CALLER_ADDR1);
unsigned long ip = get_lock_parent_ip();
current->preempt_disable_ip = ip;
......@@ -3004,7 +2994,7 @@ void preempt_count_sub(int val)
if (preempt_count() == val)
trace_preempt_on(CALLER_ADDR0, get_parent_ip(CALLER_ADDR1));
trace_preempt_on(CALLER_ADDR0, get_lock_parent_ip());
......@@ -116,9 +116,9 @@ void __local_bh_disable_ip(unsigned long ip, unsigned int cnt)
if (preempt_count() == cnt) {
current->preempt_disable_ip = get_parent_ip(CALLER_ADDR1);
current->preempt_disable_ip = get_lock_parent_ip();
trace_preempt_off(CALLER_ADDR0, get_parent_ip(CALLER_ADDR1));
trace_preempt_off(CALLER_ADDR0, get_lock_parent_ip());
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment