Commit e4302aec authored by Dan Carpenter's avatar Dan Carpenter Committed by Alexandre Belloni

rtc: pxa: fix probe function

This patch is from static analysis and I don't have the hardware to
to test it.  I think the test is reversed so now the probe function
will return success early and the last part of the function is dead

Fixes: 3cdf4ad9 ("rtc: pxa: convert to use shared sa1100 functions")
Signed-off-by: default avatarDan Carpenter <>
Signed-off-by: default avatarAlexandre Belloni <>
parent 8ee4aee5
......@@ -363,7 +363,7 @@ static int __init pxa_rtc_probe(struct platform_device *pdev)
sa1100_rtc->rtar = pxa_rtc->base + 0x4;
sa1100_rtc->rttr = pxa_rtc->base + 0xc;
ret = sa1100_rtc_init(pdev, sa1100_rtc);
if (!ret) {
if (ret) {
dev_err(dev, "Unable to init SA1100 RTC sub-device\n");
return ret;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment