Commit c2967731 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Linus Walleij

gpio: aspeed: fix compile testing warning

Gcc cannot always see that BUG_ON(1) is guaranteed to not
return, so we get a warning message in some configurations:

drivers/gpio/gpio-aspeed.c: In function 'bank_reg':
drivers/gpio/gpio-aspeed.c:244:1: error: control reaches end of non-void function [-Werror=return-type]

Using a plain BUG() is easier here and avoids the problem.

Fixes: 44ddf559 ("gpio: aspeed: Rework register type accessors")
Signed-off-by: default avatarArnd Bergmann <>
Acked-by: default avatarBenjamin Herrenschmidt <>
Signed-off-by: default avatarLinus Walleij <>
parent 80956790
......@@ -240,7 +240,7 @@ static inline void __iomem *bank_reg(struct aspeed_gpio *gpio,
case reg_cmdsrc1:
return gpio->base + bank->cmdsrc_regs + GPIO_CMDSRC_1;
#define GPIO_BANK(x) ((x) >> 5)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment