Commit b89fc2e5 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Mauro Carvalho Chehab

V4L/DVB sh_mobile_ceu: don't check platform_get_irq's return value against zero

platform_get_irq returns -ENXIO on failure, so !irq was probably
always true.  Better use (int)irq <= 0.  Note that a return value of
zero is still handled as error even though this could mean irq0.

This is a followup to 305b3228 that
changed the return value of platform_get_irq from 0 to -ENXIO on error.

Cc: David Vrabel <>
Cc: Greg Kroah-Hartman <>
Cc: Mauro Carvalho Chehab <>
Cc: Guennadi Liakhovetski <>
Cc: Magnus Damm <>
Cc: Kuninori Morimoto <>
Cc: Paul Mundt <>
Signed-off-by: default avatarUwe Kleine-König <>
Signed-off-by: default avatarGuennadi Liakhovetski <>
Signed-off-by: default avatarMauro Carvalho Chehab <>
parent 30883ea8
......@@ -1827,7 +1827,7 @@ static int __devinit sh_mobile_ceu_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
irq = platform_get_irq(pdev, 0);
if (!res || !irq) {
if (!res || (int)irq <= 0) {
dev_err(&pdev->dev, "Not enough CEU platform resources.\n");
err = -ENODEV;
goto exit;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment