Commit b2dc4110 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Linus Walleij

gpio: pca953x: remove incorrect le16_to_cpu calls

i2c_smbus commands handle the correct byte order for smbus transactions
internally. This will currently result in incorrect operation on big
endian systems.
Suggested-by: default avatarSebastian Reichel <>
Signed-off-by: default avatarAndy Shevchenko <>
Reviewed-by: default avatarSebastian Reichel <>
Signed-off-by: default avatarLinus Walleij <>
parent ef954844
......@@ -187,10 +187,9 @@ static int pca953x_write_regs_8(struct pca953x_chip *chip, int reg, u8 *val)
static int pca953x_write_regs_16(struct pca953x_chip *chip, int reg, u8 *val)
__le16 word = cpu_to_le16(get_unaligned((u16 *)val));
u16 word = get_unaligned((u16 *)val);
return i2c_smbus_write_word_data(chip->client,
reg << 1, (__force u16)word);
return i2c_smbus_write_word_data(chip->client, reg << 1, word);
static int pca957x_write_regs_16(struct pca953x_chip *chip, int reg, u8 *val)
......@@ -241,8 +240,7 @@ static int pca953x_read_regs_16(struct pca953x_chip *chip, int reg, u8 *val)
int ret;
ret = i2c_smbus_read_word_data(chip->client, reg << 1);
val[0] = (u16)ret & 0xFF;
val[1] = (u16)ret >> 8;
put_unaligned(ret, (u16 *)val);
return ret;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment