Commit a62b07e9 authored by Andreas Gruenbacher's avatar Andreas Gruenbacher Committed by Greg Kroah-Hartman

gfs2: Fix loop in gfs2_rbm_find

commit 2d29f6b9 upstream.

Fix the resource group wrap-around logic in gfs2_rbm_find that commit
e579ed4f broke.  The bug can lead to unnecessary repeated scanning of the
same bitmaps; there is a risk that future changes will turn this into an
endless loop.

Fixes: e579ed4f ("GFS2: Introduce rbm field bii")
Cc: # v3.13+
Signed-off-by: default avatarAndreas Gruenbacher <>
Signed-off-by: default avatarBob Peterson <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent dfb1922a
...@@ -1780,9 +1780,9 @@ static int gfs2_rbm_find(struct gfs2_rbm *rbm, u8 state, u32 *minext, ...@@ -1780,9 +1780,9 @@ static int gfs2_rbm_find(struct gfs2_rbm *rbm, u8 state, u32 *minext,
goto next_iter; goto next_iter;
} }
if (ret == -E2BIG) { if (ret == -E2BIG) {
n += rbm->bii - initial_bii;
rbm->bii = 0; rbm->bii = 0;
rbm->offset = 0; rbm->offset = 0;
n += (rbm->bii - initial_bii);
goto res_covered_end_of_rgrp; goto res_covered_end_of_rgrp;
} }
return ret; return ret;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment