Commit 940343c7 authored by Dave Hansen's avatar Dave Hansen Committed by Greg Kroah-Hartman

x86/selftests/pkeys: Fork() to check for state being preserved

commit e1812933 upstream.

There was a bug where the per-mm pkey state was not being preserved across
fork() in the child.  fork() is performed in the pkey selftests, but all of
the pkey activity is performed in the parent.  The child does not perform
any actions sensitive to pkey state.

To make the test more sensitive to these kinds of bugs, add a fork() where
the parent exits, and execution continues in the child.

To achieve this let the key exhaustion test not terminate at the first
allocation failure and fork after 2*NR_PKEYS loops and continue in the
Signed-off-by: 's avatarDave Hansen <>
Signed-off-by: 's avatarThomas Gleixner <>
Cc: Borislav Petkov <>
Cc: "H. Peter Anvin" <>
Cc: Peter Zijlstra <>
Cc: Michael Ellerman <>
Cc: Will Deacon <>
Cc: Andy Lutomirski <>
Cc: Joerg Roedel <>
Link: 's avatarGreg Kroah-Hartman <>
parent 992c4f69
......@@ -1133,6 +1133,21 @@ void test_pkey_syscalls_bad_args(int *ptr, u16 pkey)
void become_child(void)
pid_t forkret;
forkret = fork();
pkey_assert(forkret >= 0);
dprintf3("[%d] fork() ret: %d\n", getpid(), forkret);
if (!forkret) {
/* in the child */
/* Assumes that all pkeys other than 'pkey' are unallocated */
void test_pkey_alloc_exhaust(int *ptr, u16 pkey)
......@@ -1141,7 +1156,7 @@ void test_pkey_alloc_exhaust(int *ptr, u16 pkey)
int nr_allocated_pkeys = 0;
int i;
for (i = 0; i < NR_PKEYS*2; i++) {
for (i = 0; i < NR_PKEYS*3; i++) {
int new_pkey;
dprintf1("%s() alloc loop: %d\n", __func__, i);
new_pkey = alloc_pkey();
......@@ -1152,20 +1167,26 @@ void test_pkey_alloc_exhaust(int *ptr, u16 pkey)
if ((new_pkey == -1) && (errno == ENOSPC)) {
dprintf2("%s() failed to allocate pkey after %d tries\n",
__func__, nr_allocated_pkeys);
} else {
* Ensure the number of successes never
* exceeds the number of keys supported
* in the hardware.
pkey_assert(nr_allocated_pkeys < NR_PKEYS);
allocated_pkeys[nr_allocated_pkeys++] = new_pkey;
pkey_assert(nr_allocated_pkeys < NR_PKEYS);
allocated_pkeys[nr_allocated_pkeys++] = new_pkey;
* Make sure that allocation state is properly
* preserved across fork().
if (i == NR_PKEYS*2)
dprintf3("%s()::%d\n", __func__, __LINE__);
* ensure it did not reach the end of the loop without
* failure:
pkey_assert(i < NR_PKEYS*2);
* There are 16 pkeys supported in hardware. Three are
* allocated by the time we get here:
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment