Commit 8cbd468b authored by Yangtao Li's avatar Yangtao Li Committed by Rafael J. Wysocki

cpufreq: scmi: Fix use-after-free in scmi_cpufreq_exit()

This issue was detected with the help of Coccinelle. So
change the order of function calls to fix it.

Fixes: 1690d8bb (cpufreq: scpi/scmi: Fix freeing of dynamic OPPs)
Signed-off-by: 's avatarYangtao Li <tiny.windzz@gmail.com>
Acked-by: 's avatarViresh Kumar <viresh.kumar@linaro.org>
Acked-by: 's avatarSudeep Holla <sudeep.holla@arm.com>
Cc: 4.20+ <stable@vger.kernel.org> # 4.20+
Signed-off-by: 's avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent a3b22b9f
......@@ -187,8 +187,8 @@ static int scmi_cpufreq_exit(struct cpufreq_policy *policy)
cpufreq_cooling_unregister(priv->cdev);
dev_pm_opp_free_cpufreq_table(priv->cpu_dev, &policy->freq_table);
kfree(priv);
dev_pm_opp_remove_all_dynamic(priv->cpu_dev);
kfree(priv);
return 0;
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment