Commit 84bc8868 authored by Vincent BENAYOUN's avatar Vincent BENAYOUN Committed by David S. Miller

inetdevice: fixed signed integer overflow

There could be a signed overflow in the following code.

The expression, (32-logmask) is comprised between 0 and 31 included.
It may be equal to 31.
In such a case the left shift will produce a signed integer overflow.
According to the C99 Standard, this is an undefined behavior.
A simple fix is to replace the signed int 1 with the unsigned int 1U.
Signed-off-by: default avatarVincent BENAYOUN <>
Signed-off-by: default avatarDavid S. Miller <>
parent b23dc5a7
......@@ -242,7 +242,7 @@ static inline void in_dev_put(struct in_device *idev)
static __inline__ __be32 inet_make_mask(int logmask)
if (logmask)
return htonl(~((1<<(32-logmask))-1));
return htonl(~((1U<<(32-logmask))-1));
return 0;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment