Commit 729c4104 authored by Arthur Kiyanovski's avatar Arthur Kiyanovski Committed by Greg Kroah-Hartman

net: ena: fix race between link up and device initalization

[ Upstream commit e1f1bd9b ]

Fix race condition between ena_update_on_link_change() and

This race can occur if link notification arrives while the driver
is performing a reset sequence. In this case link can be set up,
enabling the device, before it is fully restored. If packets are
sent at this time, the driver might access uninitialized data
structures, causing kernel crash.

Move the clearing of ENA_FLAG_ONGOING_RESET and netif_carrier_on()
after ena_up() to ensure the device is ready when link is set up.

Fixes: d18e4f68 ("net: ena: fix race condition between device reset and link up setup")
Signed-off-by: 's avatarArthur Kiyanovski <>
Signed-off-by: 's avatarDavid S. Miller <>
Signed-off-by: 's avatarGreg Kroah-Hartman <>
parent 01965b35
......@@ -2663,11 +2663,6 @@ static int ena_restore_device(struct ena_adapter *adapter)
goto err_device_destroy;
clear_bit(ENA_FLAG_ONGOING_RESET, &adapter->flags);
/* Make sure we don't have a race with AENQ Links state handler */
if (test_bit(ENA_FLAG_LINK_UP, &adapter->flags))
rc = ena_enable_msix_and_set_admin_interrupts(adapter,
if (rc) {
......@@ -2684,6 +2679,11 @@ static int ena_restore_device(struct ena_adapter *adapter)
set_bit(ENA_FLAG_DEVICE_RUNNING, &adapter->flags);
clear_bit(ENA_FLAG_ONGOING_RESET, &adapter->flags);
if (test_bit(ENA_FLAG_LINK_UP, &adapter->flags))
mod_timer(&adapter->timer_service, round_jiffies(jiffies + HZ));
"Device reset completed successfully, Driver info: %s\n",
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment