Commit 4f2ab5e1 authored by Charles Keepax's avatar Charles Keepax Committed by Takashi Iwai

ALSA: compress: Fix stop handling on compressed capture streams

It is normal user behaviour to start, stop, then start a stream
again without closing it. Currently this works for compressed
playback streams but not capture ones.

The states on a compressed capture stream go directly from OPEN to
PREPARED, unlike a playback stream which moves to SETUP and waits
for a write of data before moving to PREPARED. Currently however,
when a stop is sent the state is set to SETUP for both types of
streams. This leaves a capture stream in the situation where a new
start can't be sent as that requires the state to be PREPARED and
a new set_params can't be sent as that requires the state to be
OPEN. The only option being to close the stream, and then reopen.

Correct this issues by allowing snd_compr_drain_notify to set the
state depending on the stream direction, as we already do in

Fixes: 49bb6402 ("ALSA: compress_core: Add support for capture streams")
Signed-off-by: 's avatarCharles Keepax <>
Cc: <>
Signed-off-by: 's avatarTakashi Iwai <>
parent 3bff2407
......@@ -173,7 +173,11 @@ static inline void snd_compr_drain_notify(struct snd_compr_stream *stream)
if (snd_BUG_ON(!stream))
stream->runtime->state = SNDRV_PCM_STATE_SETUP;
if (stream->direction == SND_COMPRESS_PLAYBACK)
stream->runtime->state = SNDRV_PCM_STATE_SETUP;
stream->runtime->state = SNDRV_PCM_STATE_PREPARED;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment