Commit 47fa7bbc authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman

mfd: ab8500-core: Return zero in get_register_interruptible()

[ Upstream commit 10628e3e ]

This function is supposed to return zero on success or negative error
codes on error.  Unfortunately, there is a bug so it sometimes returns
non-zero, positive numbers on success.

I noticed this bug during review and I can't test it.  It does appear
that the return is sometimes propogated back to _regmap_read() where all
non-zero returns are treated as failure so this may affect run time.

Fixes: 47c16975 ("mfd: Align ab8500 with the abx500 interface")
Signed-off-by: 's avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: 's avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: 's avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: 's avatarSasha Levin <sashal@kernel.org>
parent 940eea61
......@@ -261,7 +261,7 @@ static int get_register_interruptible(struct ab8500 *ab8500, u8 bank,
mutex_unlock(&ab8500->lock);
dev_vdbg(ab8500->dev, "rd: addr %#x => data %#x\n", addr, ret);
return ret;
return (ret < 0) ? ret : 0;
}
static int ab8500_get_register(struct device *dev, u8 bank,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment