Commit 446266b0 authored by Daniel Borkmann's avatar Daniel Borkmann Committed by David S. Miller

net: rtm_to_ifaddr: free ifa if ifa_cacheinfo processing fails

Commit 5c766d64 ("ipv4: introduce address lifetime") leaves the ifa
resource that was allocated via inet_alloc_ifa() unfreed when returning
the function with -EINVAL. Thus, free it first via inet_free_ifa().
Signed-off-by: default avatarDaniel Borkmann <>
Reviewed-by: default avatarJiri Pirko <>
Signed-off-by: default avatarDavid S. Miller <>
parent 9bb8eeb5
......@@ -772,7 +772,7 @@ static struct in_ifaddr *rtm_to_ifaddr(struct net *net, struct nlmsghdr *nlh,
ci = nla_data(tb[IFA_CACHEINFO]);
if (!ci->ifa_valid || ci->ifa_prefered > ci->ifa_valid) {
err = -EINVAL;
goto errout;
goto errout_free;
*pvalid_lft = ci->ifa_valid;
*pprefered_lft = ci->ifa_prefered;
......@@ -780,6 +780,8 @@ static struct in_ifaddr *rtm_to_ifaddr(struct net *net, struct nlmsghdr *nlh,
return ifa;
return ERR_PTR(err);
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment