Commit 29b00e60 authored by Darrick J. Wong's avatar Darrick J. Wong Committed by Linus Torvalds

tmpfs: fix uninitialized return value in shmem_link

When we made the shmem_reserve_inode call in shmem_link conditional, we
forgot to update the declaration for ret so that it always has a known
value.  Dan Carpenter pointed out this deficiency in the original patch.

Fixes: 1062af92 ("tmpfs: fix link accounting when a tmpfile is linked in")
Reported-by: default avatarDan Carpenter <>
Signed-off-by: default avatarDarrick J. Wong <>
Signed-off-by: default avatarHugh Dickins <>
Cc: Matej Kupljen <>
Cc: Al Viro <>
Cc: Andrew Morton <>
Signed-off-by: default avatarLinus Torvalds <>
parent 53a41cb7
......@@ -2848,7 +2848,7 @@ static int shmem_create(struct inode *dir, struct dentry *dentry, umode_t mode,
static int shmem_link(struct dentry *old_dentry, struct inode *dir, struct dentry *dentry)
struct inode *inode = d_inode(old_dentry);
int ret;
int ret = 0;
* No ordinary (disk based) filesystem counts links as inodes;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment