Commit 216c4e9d authored by Dan Carpenter's avatar Dan Carpenter Committed by Rafael J. Wysocki

PowerCap: Fix an error code in powercap_register_zone()

In the current code we accidentally return the successful result from
idr_alloc() instead of a negative error pointer.  The caller is looking
for an error pointer and so it treats the returned value as a valid
pointer.

This one might be a bit serious because if it lets people get around the
kernel's protection for remapping NULL.  I'm not sure.

Fixes: 75d2364e (PowerCap: Add class driver)
Signed-off-by: 's avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: 's avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: 's avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 4486740d
......@@ -538,6 +538,7 @@ struct powercap_zone *powercap_register_zone(
power_zone->id = result;
idr_init(&power_zone->idr);
result = -ENOMEM;
power_zone->name = kstrdup(name, GFP_KERNEL);
if (!power_zone->name)
goto err_name_alloc;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment