Commit 16d4d75d authored by Daniel Vetter's avatar Daniel Vetter Committed by Greg Kroah-Hartman

drm/nouveau: Stop using drm_crtc_force_disable

[ Upstream commit 934c5b32 ]

The correct way for legacy drivers to update properties that need to
do a full modeset, is to do a full modeset.

Note that we don't need to call the drm_mode_config_internal helper
because we're not changing any of the refcounted paramters.

v2: Fixup error handling (Ville). Since the old code didn't bother
I decided to just delete it instead of adding even more code for just
error handling.

Cc: Ville Syrjälä <>
Reviewed-by: Alex Deucher <> (v1)
Cc: Sean Paul <>
Signed-off-by: 's avatarDaniel Vetter <>
Link: 's avatarSasha Levin <>
parent bfb59eab
......@@ -750,7 +750,9 @@ static int nv17_tv_set_property(struct drm_encoder *encoder,
/* Disable the crtc to ensure a full modeset is
* performed whenever it's turned on again. */
if (crtc)
drm_crtc_helper_set_mode(crtc, &crtc->mode,
crtc->x, crtc->y,
return 0;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment