Commit 0fc78fa0 authored by Mircea Caprioru's avatar Mircea Caprioru Committed by Greg Kroah-Hartman

iio: dac: ad5686: fix bit shift read register

commit 0e76df5c upstream.

This patch solves the register readback issue with the bit shift. When the
dac resolution was lower than the register size (ex. 12 bits out of 16
bits) the readback value was not shifted with the difference in bits and
the value was higher. Also a mask is applied on the read value in order to
get the value relative to the actual bit size.

Fixes: 0357e488 ("iio:dac:ad5686: Refactor the driver")
Signed-off-by: default avatarMircea Caprioru <>
Cc: <>
Signed-off-by: default avatarJonathan Cameron <>
Signed-off-by: default avatarGreg Kroah-Hartman <>
parent 30533049
......@@ -124,7 +124,8 @@ static int ad5686_read_raw(struct iio_dev *indio_dev,
if (ret < 0)
return ret;
*val = ret;
*val = (ret >> chan->scan_type.shift) &
GENMASK(chan->scan_type.realbits - 1, 0);
return IIO_VAL_INT;
*val = st->vref_mv;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment