• Håkon Bugge's avatar
    IB/cm: Remove unused and erroneous msg sequence encoding · 87a37ce9
    Håkon Bugge authored
    In cm_form_tid(), a two bit message sequence number is OR'ed into bit
    31-30 of the lower TID value.
    
    After commit f06d2653 ("IB/cm: Randomize starting comm ID"), the
    local_id is XOR'ed with a 32-bit random value. Hence, bit 31-30 in the
    lower TID now has an arbitrarily value and it makes no sense to OR in
    the message sequence number.
    
    Adding to that, the evolution in use of IDR routines in cm_alloc_id()
    has always had the possibility of returning a value with bit 30 set.
    
    In addition, said bits are never checked.
    
    Hence, remove the encoding and the corresponding enum.
    Signed-off-by: 's avatarHåkon Bugge <haakon.bugge@oracle.com>
    Signed-off-by: 's avatarJason Gunthorpe <jgg@mellanox.com>
    87a37ce9
cm_msgs.h 21.2 KB