• Finn Thain's avatar
    macintosh/adb: Rework printk output again · 2341629e
    Finn Thain authored
    Avoid the KERN_CONT problem by avoiding message fragments. The problem
    arises during async ADB bus probing, when ADB messages may get mixed up
    with other messages. See also, commit 4bcc595c ("printk: reinstate
    KERN_CONT for printing continuation lines").
    
    Remove a number of printk() continuation lines by logging handler
    changes in adb_try_handler_change() instead.
    
    This patch addresses the problematic use of "\n" at the beginning of
    pr_cont() messages, which got overlooked in commit f2be6295
    ("macintosh/adb: Properly mark continued kernel messages").
    
    That commit also changed printk(KERN_DEBUG ...) to pr_debug(...), which
    hinders work on low-level ADB driver bugs. Revert that change.
    
    Cc: Andreas Schwab <schwab@linux-m68k.org>
    Tested-by: default avatarStan Johnson <userm57@yahoo.com>
    Signed-off-by: default avatarFinn Thain <fthain@telegraphics.com.au>
    Signed-off-by: Michael Ellerman's avatarMichael Ellerman <mpe@ellerman.id.au>
    2341629e
adbhid.c 34.3 KB