• Arnd Bergmann's avatar
    leds: ktd2692: avoid harmless maybe-uninitialized warning · cbe99c53
    Arnd Bergmann authored
    gcc gets confused about the control flow in ktd2692_parse_dt(), causing
    it to warn about what seems like a potential bug:
    
    drivers/leds/leds-ktd2692.c: In function 'ktd2692_probe':
    drivers/leds/leds-ktd2692.c:244:15: error: '*((void *)&led_cfg+8)' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    drivers/leds/leds-ktd2692.c:225:7: error: 'led_cfg.flash_max_microamp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    drivers/leds/leds-ktd2692.c:232:3: error: 'led_cfg.movie_max_microamp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
    
    The code is fine, and slightly reworking it in an equivalent way lets
    gcc figure that out too, which gets rid of the warning.
    
    Fixes: 77e7915b ("leds: ktd2692: Add missing of_node_put")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Acked-by: Pavel Machek's avatarPavel Machek <pavel@ucw.cz>
    Signed-off-by: default avatarJacek Anaszewski <jacek.anaszewski@gmail.com>
    cbe99c53
leds-ktd2692.c 11 KB