• Jacek Anaszewski's avatar
    leds: core: Fix regression caused by commit 2b83ff96 · 7b6af2c5
    Jacek Anaszewski authored
    Commit 2b83ff96 ("led: core: Fix brightness setting when setting delay_off=0")
    replaced del_timer_sync(&led_cdev->blink_timer) with led_stop_software_blink()
    in led_blink_set(), which additionally clears LED_BLINK_SW flag as well as
    zeroes blink_delay_on and blink_delay_off properties of the struct led_classdev.
    Cleansing of the latter ones wasn't required to fix the original issue but
    wasn't considered harmful. It nonetheless turned out to be so in case when
    pointer to one or both props is passed to led_blink_set() like in the
    ledtrig-timer.c. In such cases zeroes are passed later in delay_on and/or
    delay_off arguments to led_blink_setup(), which results either in stopping
    the software blinking or setting blinking frequency always to 1Hz.
    Avoid using led_stop_software_blink() and add a single call required
    to clear LED_BLINK_SW flag, which was the only needed modification to
    fix the original issue.
    Fixes 2b83ff96 ("led: core: Fix brightness setting when setting delay_off=0")
    Signed-off-by: default avatarJacek Anaszewski <jacek.anaszewski@gmail.com>
led-core.c 8.71 KB