• Lv Zheng's avatar
    ACPI / IBFT: Fix incorrect <acpi/acpi.h> inclusion in iSCSI boot firmware module · 9d24622c
    Lv Zheng authored
    To avoid build problems and breaking dependencies between ACPI header
    files, <acpi/acpi.h> should not be included directly by code outside
    of the ACPI core subsystem, but this is done by the ACPI iSCSI
    Boot Firmware code.
    
    The iBFT specification doesn't mention whether or not it can appear
    on a non-ACPI platform, but is says that ACPI 3.0b defines the
    mechanism.  The current CONFIG_ISCSI_IBFT_FIND code doesn't use the
    ACPI tables API to locate the table, so it doesn't rely on CONFIG_ACPI
    directly.
    
    However, since iBFT is is an ACPI-based mechanism (please refer to
    the documentation link below for more information), it should be
    correct to make CONFIG_ISCSI_IBFT_FIND depend on CONFIG_ACPI (even
    though the table location can be implemented without using ACPI
    tables API).
    
    After that change, include/linux/iscsi_ibft.h can be modified to
    include <linux/acpi.h> instead of <acpi/acpi.h> as appropriate.
    
    References: http://www.microsoft.com/whdc/system/platform/firmware/ibft.mspx
    Cc: Konrad Rzeszutek Wilk <konrad@kernel.org>
    Cc: Peter Jones <pjones@redhat.com>
    Signed-off-by: default avatarLv Zheng <lv.zheng@intel.com>
    [rjw: Subject and changelog]
    Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    9d24622c
iscsi_ibft.h 1.28 KB