• NeilBrown's avatar
    sched: Change wait_for_completion_*_timeout() to return a signed long · 6bf41237
    NeilBrown authored
    wait_for_completion_*_timeout() can return:
    
       0: if the wait timed out
     -ve: if the wait was interrupted
     +ve: if the completion was completed.
    
    As they currently return an 'unsigned long', the last two cases
    are not easily distinguished which can easily result in buggy
    code, as is the case for the recently added
    wait_for_completion_interruptible_timeout() call in
    net/sunrpc/cache.c
    
    So change them both to return 'long'.  As MAX_SCHEDULE_TIMEOUT
    is LONG_MAX, a large +ve return value should never overflow.
    Signed-off-by: default avatarNeilBrown <neilb@suse.de>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: J.  Bruce Fields <bfields@fieldses.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    LKML-Reference: <20110105125016.64ccab0e@notabene.brown>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    6bf41237
completion.h 3.23 KB