• Jeff Mahoney's avatar
    reiserfs: fix corruption introduced by balance_leaf refactor · 27d0e5bc
    Jeff Mahoney authored
    Commits f1f007c3 (reiserfs: balance_leaf refactor, pull out
    balance_leaf_insert_left) and cf22df18 (reiserfs: balance_leaf
    refactor, pull out balance_leaf_paste_left) missed that the `body'
    pointer was getting repositioned. Subsequent users of the pointer
    would expect it to be repositioned, and as a result, parts of the
    tree would get overwritten. The most common observed corruption
    is indirect block pointers being overwritten.
    Since the body value isn't actually used anymore in the called routines,
    we can pass back the offset it should be shifted. We constify the body
    and ih pointers in the balance_leaf as a mostly-free preventative measure.
    Cc: <stable@vger.kernel.org> # 3.16
    Reported-and-tested-by: default avatarJeff Chua <jeff.chua.linux@gmail.com>
    Signed-off-by: default avatarJeff Mahoney <jeffm@suse.com>
    Signed-off-by: default avatarJan Kara <jack@suse.cz>
reiserfs.h 117 KB