1. 11 Apr, 2014 1 commit
  2. 31 Mar, 2014 1 commit
    • David Ertman's avatar
      e1000e: Fix no connectivity when driver loaded with cable out · b20a7744
      David Ertman authored
      In commit da1e2046
      
      , the flow for enabling/disabling an Si errata
      workaround (e1000_lv_jumbo_workaround_ich8lan) was changed to fix a problem
      with iAMT connections dropping on interface down with jumbo frames set.
      Part of this change was to move the function call disabling the workaround
      to e1000e_down() from the e1000_setup_rctl() function.  The mechanic for
      disabling of this workaround involves writing several MAC and PHY registers
      back to hardware defaults.
      
      After this commit, when the driver is loaded with the cable out, the PHY
      registers are not programmed with the correct default values.  This causes
      the device to be capable of transmitting packets, but is unable to recieve
      them until this workaround is called.
      
      The flow of e1000e's open code relies upon calling the above workaround to
      expicitly program these registers either with jumbo frame appropriate settings
      or h/w defaults on 82579 and newer hardware.
      
      Fix this issue by adding logic to e1000_setup_rctl() that not only calls
      e1000_lv_jumbo_workaround_ich8lan() when jumbo frames are set, to enable the
      workaround, but also calls this function to explicitly disable the workaround
      in the case that jumbo frames are not set.
      Signed-off-by: default avatarDave Ertman <davidx.m.ertman@intel.com>
      Tested-by: default avatarJeff Pieper <jeffrey.e.pieper@intel.com>
      Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      b20a7744
  3. 28 Mar, 2014 2 commits
  4. 20 Mar, 2014 2 commits
  5. 18 Mar, 2014 1 commit
  6. 13 Mar, 2014 1 commit
  7. 08 Mar, 2014 6 commits
  8. 18 Feb, 2014 1 commit
  9. 16 Jan, 2014 1 commit
    • Mika Westerberg's avatar
      e1000e: Fix compilation warning when !CONFIG_PM_SLEEP · 38a529b5
      Mika Westerberg authored
      Commit 7509963c
      
       (e1000e: Fix a compile flag mis-match for
      suspend/resume) moved suspend and resume hooks to be available when
      CONFIG_PM is set. However, it can be set even if CONFIG_PM_SLEEP is not set
      causing following warnings to be emitted:
      
      drivers/net/ethernet/intel/e1000e/netdev.c:6178:12: warning:
        	‘e1000_suspend’ defined but not used [-Wunused-function]
      
      drivers/net/ethernet/intel/e1000e/netdev.c:6185:12: warning:
      	‘e1000_resume’ defined but not used [-Wunused-function]
      
      To fix this make the hooks to be available only when CONFIG_PM_SLEEP is set
      and remove CONFIG_PM wrapping from driver ops because this is already
      handled by SET_SYSTEM_SLEEP_PM_OPS() and SET_RUNTIME_PM_OPS().
      Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
      Cc: Dave Ertman <davidx.m.ertman@intel.com>
      Cc: Aaron Brown <aaron.f.brown@intel.com>
      Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
      Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
      38a529b5
  10. 18 Dec, 2013 1 commit
  11. 21 Nov, 2013 1 commit
  12. 14 Nov, 2013 1 commit
  13. 21 Sep, 2013 1 commit
    • Russell King's avatar
      DMA-API: net: intel/e1000e: fix 32-bit DMA mask handling · 718a39eb
      Russell King authored
      
      
      The fallback to 32-bit DMA mask is rather odd:
      	err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(64));
      	if (!err) {
      		err = dma_set_coherent_mask(&pdev->dev, DMA_BIT_MASK(64));
      		if (!err)
      			pci_using_dac = 1;
      	} else {
      		err = dma_set_mask(&pdev->dev, DMA_BIT_MASK(32));
      		if (err) {
      			err = dma_set_coherent_mask(&pdev->dev,
      						    DMA_BIT_MASK(32));
      			if (err) {
      				dev_err(&pdev->dev,
      					"No usable DMA configuration, aborting\n");
      				goto err_dma;
      			}
      		}
      	}
      This means we only set the coherent DMA mask in the fallback path if
      the DMA mask set failed, which is silly.  This fixes it to set the
      coherent DMA mask only if dma_set_mask() succeeded, and to error out
      if either fails.
      Acked-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
      Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
      718a39eb
  14. 13 Sep, 2013 1 commit
  15. 22 Aug, 2013 2 commits
  16. 28 Jul, 2013 6 commits
  17. 21 May, 2013 2 commits
  18. 26 Apr, 2013 1 commit
  19. 19 Apr, 2013 3 commits
  20. 28 Mar, 2013 2 commits
  21. 27 Mar, 2013 1 commit
  22. 08 Mar, 2013 2 commits