1. 13 Sep, 2017 1 commit
  2. 09 Sep, 2017 1 commit
  3. 16 Jun, 2017 1 commit
  4. 07 Jun, 2017 1 commit
    • David S. Miller's avatar
      net: Fix inconsistent teardown and release of private netdev state. · cf124db5
      David S. Miller authored
      Network devices can allocate reasources and private memory using
      netdev_ops->ndo_init().  However, the release of these resources
      can occur in one of two different places.
      Either netdev_ops->ndo_uninit() or netdev->destructor().
      The decision of which operation frees the resources depends upon
      whether it is necessary for all netdev refs to be released before it
      is safe to perform the freeing.
      netdev_ops->ndo_uninit() presumably can occur right after the
      NETDEV_UNREGISTER notifier completes and the unicast and multicast
      address lists are flushed.
      netdev->destructor(), on the other hand, does not run until the
      netdev references all go away.
      Further complicating the situation is that netdev->destructor()
      almost universally does also a free_netdev().
      This creates a problem for the logic in register_netdevice().
      Because all callers of register_netdevice() manage the freeing
      of the netdev, and invoke free_netdev(dev) if register_netdevice()
      If netdev_ops->ndo_init() succeeds, but something else fails inside
      of register_netdevice(), it does call ndo_ops->ndo_uninit().  But
      it is not able to invoke netdev->destructor().
      This is because netdev->destructor() will do a free_netdev() and
      then the caller of register_netdevice() will do the same.
      However, this means that the resources that would normally be released
      by netdev->destructor() will not be.
      Over the years drivers have added local hacks to deal with this, by
      invoking their destructor parts by hand when register_netdevice()
      Many drivers do not try to deal with this, and instead we have leaks.
      Let's close this hole by formalizing the distinction between what
      private things need to be freed up by netdev->destructor() and whether
      the driver needs unregister_netdevice() to perform the free_netdev().
      netdev->priv_destructor() performs all actions to free up the private
      resources that used to be freed by netdev->destructor(), except for
      netdev->needs_free_netdev is a boolean that indicates whether
      free_netdev() should be done at the end of unregister_netdevice().
      Now, register_netdevice() can sanely release all resources after
      ndo_ops->ndo_init() succeeds, by invoking both ndo_ops->ndo_uninit()
      and netdev->priv_destructor().
      And at the end of unregister_netdevice(), we invoke
      netdev->priv_destructor() and optionally call free_netdev().
      Signed-off-by: default avatarDavid S. Miller <[email protected]>
  5. 21 Apr, 2017 1 commit
    • Craig Gallek's avatar
      ip_tunnel: Allow policy-based routing through tunnels · 9830ad4c
      Craig Gallek authored
      This feature allows the administrator to set an fwmark for
      packets traversing a tunnel.  This allows the use of independent
      routing tables for tunneled packets without the use of iptables.
      There is no concept of per-packet routing decisions through IPv4
      tunnels, so this implementation does not need to work with
      per-packet route lookups as the v6 implementation may
      (with IP6_TNL_F_USE_ORIG_FWMARK).
      Further, since the v4 tunnel ioctls share datastructures
      (which can not be trivially modified) with the kernel's internal
      tunnel configuration structures, the mark attribute must be stored
      in the tunnel structure itself and passed as a parameter when
      creating or changing tunnel attributes.
      Signed-off-by: default avatarCraig Gallek <[email protected]>
      Signed-off-by: default avatarDavid S. Miller <[email protected]>
  6. 18 Nov, 2016 1 commit
    • Alexey Dobriyan's avatar
      netns: make struct pernet_operations::id unsigned int · c7d03a00
      Alexey Dobriyan authored
      Make struct pernet_operations::id unsigned.
      There are 2 reasons to do so:
      This field is really an index into an zero based array and
      thus is unsigned entity. Using negative value is out-of-bound
      access by definition.
      On x86_64 unsigned 32-bit data which are mixed with pointers
      via array indexing or offsets added or subtracted to pointers
      are preffered to signed 32-bit data.
      "int" being used as an array index needs to be sign-extended
      to 64-bit before being used.
      	void f(long *p, int i)
        roughly translates to
      	movsx	rsi, esi
      	mov	rdi, [rsi+...]
      	call 	g
      MOVSX is 3 byte instruction which isn't necessary if the variable is
      unsigned because x86_64 is zero extending by default.
      Now, there is net_generic() function which, you guessed it right, uses
      "int" as an array index:
      	static inline void *net_generic(const struct net *net, int id)
      		ptr = ng->ptr[id - 1];
      And this function is used a lot, so those sign extensions add up.
      Patch snipes ~1730 bytes on allyesconfig kernel (without all junk
      messing with code generation):
      	add/remove: 0/0 grow/shrink: 70/598 up/down: 396/-2126 (-1730)
      Unfortunately some functions actually grow bigger.
      This is a semmingly random artefact of code generation with register
      allocator being used differently. gcc decides that some variable
      needs to live in new r8+ registers and every access now requires REX
      prefix. Or it is shifted into r12, so [r12+0] addressing mode has to be
      used which is longer than [r8]
      However, overall balance is in negative direction:
      	add/remove: 0/0 grow/shrink: 70/598 up/down: 396/-2126 (-1730)
      	function                                     old     new   delta
      	nfsd4_lock                                  3886    3959     +73
      	tipc_link_build_proto_msg                   1096    1140     +44
      	mac80211_hwsim_new_radio                    2776    2808     +32
      	tipc_mon_rcv                                1032    1058     +26
      	svcauth_gss_legacy_init                     1413    1429     +16
      	tipc_bcbase_select_primary                   379     392     +13
      	nfsd4_exchange_id                           1247    1260     +13
      	nfsd4_setclientid_confirm                    782     793     +11
      	put_client_renew_locked                      494     480     -14
      	ip_set_sockfn_get                            730     716     -14
      	geneve_sock_add                              829     813     -16
      	nfsd4_sequence_done                          721     703     -18
      	nlmclnt_lookup_host                          708     686     -22
      	nfsd4_lockt                                 1085    1063     -22
      	nfs_get_client                              1077    1050     -27
      	tcf_bpf_init                                1106    1076     -30
      	nfsd4_encode_fattr                          5997    5930     -67
      	Total: Before=154856051, After=154854321, chg -0.00%
      Signed-off-by: default avatarAlexey Dobriyan <[email protected]>
      Signed-off-by: default avatarDavid S. Miller <[email protected]>
  7. 20 Oct, 2016 1 commit
  8. 17 Sep, 2016 1 commit
  9. 16 Jun, 2016 1 commit
  10. 20 May, 2016 1 commit
  11. 29 Apr, 2016 1 commit
  12. 24 Feb, 2016 1 commit
    • Bernie Harris's avatar
      tunnel: Clear IPCB(skb)->opt before dst_link_failure called · 5146d1f1
      Bernie Harris authored
      IPCB may contain data from previous layers (in the observed case the
      qdisc layer). In the observed scenario, the data was misinterpreted as
      ip header options, which later caused the ihl to be set to an invalid
      value (<5). This resulted in an infinite loop in the mips implementation
      of ip_fast_csum.
      This patch clears IPCB(skb)->opt before dst_link_failure can be called for
      various types of tunnels. This change only applies to encapsulated ipv4
      The code introduced in 11c21a30 which clears all of IPCB has been removed
      to be consistent with these changes, and instead the opt field is cleared
      unconditionally in ip_tunnel_xmit. The change in ip_tunnel_xmit applies to
      SIT, GRE, and IPIP tunnels.
      The relevant vti, l2tp, and pptp functions already contain similar code for
      clearing the IPCB.
      Signed-off-by: default avatarBernie Harris <[email protected]>
      Signed-off-by: default avatarDavid S. Miller <[email protected]>
  13. 17 Feb, 2016 1 commit
  14. 10 Feb, 2016 1 commit
    • David Wragg's avatar
      vxlan, gre, geneve: Set a large MTU on ovs-created tunnel devices · 7e059158
      David Wragg authored
      Prior to 4.3, openvswitch tunnel vports (vxlan, gre and geneve) could
      transmit vxlan packets of any size, constrained only by the ability to
      send out the resulting packets.  4.3 introduced netdevs corresponding
      to tunnel vports.  These netdevs have an MTU, which limits the size of
      a packet that can be successfully encapsulated.  The default MTU
      values are low (1500 or less), which is awkwardly small in the context
      of physical networks supporting jumbo frames, and leads to a
      conspicuous change in behaviour for userspace.
      Instead, set the MTU on openvswitch-created netdevs to be the relevant
      maximum (i.e. the maximum IP packet size minus any relevant overhead),
      effectively restoring the behaviour prior to 4.3.
      Signed-off-by: default avatarDavid Wragg <[email protected]>
      Signed-off-by: default avatarDavid S. Miller <[email protected]>
  15. 26 Dec, 2015 1 commit
  16. 30 Nov, 2015 1 commit
  17. 10 Aug, 2015 1 commit
  18. 08 Jul, 2015 1 commit
  19. 07 Apr, 2015 1 commit
  20. 03 Apr, 2015 2 commits
  21. 02 Apr, 2015 1 commit
  22. 19 Jan, 2015 1 commit
  23. 16 Dec, 2014 2 commits
  24. 12 Nov, 2014 1 commit
  25. 05 Nov, 2014 1 commit
    • Tom Herbert's avatar
      net: Move fou_build_header into fou.c and refactor · 63487bab
      Tom Herbert authored
      Move fou_build_header out of ip_tunnel.c and into fou.c splitting
      it up into fou_build_header, gue_build_header, and fou_build_udp.
      This allows for other users for TX of FOU or GUE. Change ip_tunnel_encap
      to call fou_build_header or gue_build_header based on the tunnel
      encapsulation type. Similarly, added fou_encap_hlen and gue_encap_hlen
      functions which are called by ip_encap_hlen. New net/fou.h has
      prototypes and defines for this.
      Added NET_FOU_IP_TUNNELS configuration. When this is set, IP tunnels
      can use FOU/GUE and fou module is also selected.
      Signed-off-by: default avatarTom Herbert <[email protected]>
      Signed-off-by: default avatarDavid S. Miller <[email protected]>
  26. 03 Oct, 2014 2 commits
  27. 26 Sep, 2014 1 commit
  28. 22 Sep, 2014 1 commit
  29. 19 Sep, 2014 1 commit
  30. 30 Jul, 2014 1 commit
  31. 15 Jul, 2014 1 commit
    • Tom Gundersen's avatar
      net: set name_assign_type in alloc_netdev() · c835a677
      Tom Gundersen authored
      Extend alloc_netdev{,_mq{,s}}() to take name_assign_type as argument, and convert
      all users to pass NET_NAME_UNKNOWN.
      Coccinelle patch:
      expression sizeof_priv, name, setup, txqs, rxqs, count;
      -alloc_netdev_mqs(sizeof_priv, name, setup, txqs, rxqs)
      +alloc_netdev_mqs(sizeof_priv, name, NET_NAME_UNKNOWN, setup, txqs, rxqs)
      -alloc_netdev_mq(sizeof_priv, name, setup, count)
      +alloc_netdev_mq(sizeof_priv, name, NET_NAME_UNKNOWN, setup, count)
      -alloc_netdev(sizeof_priv, name, setup)
      +alloc_netdev(sizeof_priv, name, NET_NAME_UNKNOWN, setup)
      v9: move comments here from the wrong commit
      Signed-off-by: default avatarTom Gundersen <[email protected]>
      Reviewed-by: David Rheinsberg's avatarDavid Herrmann <[email protected]>
      Signed-off-by: default avatarDavid S. Miller <[email protected]>
  32. 09 Jul, 2014 1 commit
    • Dmitry Popov's avatar
      ip_tunnel: fix ip_tunnel_lookup · e0056593
      Dmitry Popov authored
      This patch fixes 3 similar bugs where incoming packets might be routed into
      wrong non-wildcard tunnels:
      1) Consider the following setup:
          ip address add dev eth0
          ip address add dev eth0
          ip tunnel add ipip1 remote local mode ipip dev eth0
          ip link set ipip1 up
      Incoming ipip packets from were routed into ipip1 even if it has dst = Moreover even if there was wildcard tunnel like
         ip tunnel add ipip0 remote local any mode ipip dev eth0
      but it was created before explicit one (with local, incoming ipip
      packets with src = and dst = were still routed into ipip1.
      Same issue existed with all tunnels that use ip_tunnel_lookup (gre, vti)
      2)  ip address add dev eth0
          ip tunnel add ipip1 remote local mode ipip dev eth0
          ip link set ipip1 up
      Incoming ipip packets with dst = were routed into ipip1, no matter what
      src address is. Any remote ip address which has ip_tunnel_hash = 0 raised this
      issue, is just an example, there are more than 4 million of them.
      And again, wildcard tunnel like
         ip tunnel add ipip0 remote any local mode ipip dev eth0
      wouldn't be ever matched if it was created before explicit tunnel like above.
      Gre & vti tunnels had the same issue.
      3)  ip address add dev eth0
          ip tunnel add gre1 remote local key 1 mode gre dev eth0
          ip link set gre1 up
      Any incoming gre packet with key = 1 were routed into gre1, no matter what
      src/dst addresses are. Any remote ip address which has ip_tunnel_hash = 0 raised
      the issue, is just an example, there are more than 4 million of them.
      Wildcard tunnel like
         ip tunnel add gre2 remote any local any key 1 mode gre dev eth0
      wouldn't be ever matched if it was created before explicit tunnel like above.
      All this stuff happened because while looking for a wildcard tunnel we didn't
      check that matched tunnel is a wildcard one. Fixed.
      Signed-off-by: default avatarDmitry Popov <[email protected]>
      Signed-off-by: default avatarDavid S. Miller <[email protected]>
  33. 26 Jun, 2014 1 commit
    • Eric Dumazet's avatar
      ipv4: fix dst race in sk_dst_get() · f8864972
      Eric Dumazet authored
      When IP route cache had been removed in linux-3.6, we broke assumption
      that dst entries were all freed after rcu grace period. DST_NOCACHE
      dst were supposed to be freed from dst_release(). But it appears
      we want to keep such dst around, either in UDP sockets or tunnels.
      In sk_dst_get() we need to make sure dst refcount is not 0
      before incrementing it, or else we might end up freeing a dst
      DST_NOCACHE set on a dst does not mean this dst can not be attached
      to a socket or a tunnel.
      Then, before actual freeing, we need to observe a rcu grace period
      to make sure all other cpus can catch the fact the dst is no longer
      Signed-off-by: default avatarEric Dumazet <[email protected]>
      Reported-by: default avatarDormando <[email protected]>
      Signed-off-by: default avatarDavid S. Miller <[email protected]>
  34. 11 Jun, 2014 2 commits
    • Dmitry Popov's avatar
      ip_tunnel: fix i_key matching in ip_tunnel_find · 5ce54af1
      Dmitry Popov authored
      Some tunnels (though only vti as for now) can use i_key just for internal use:
      for example vti uses it for fwmark'ing incoming packets. So raw i_key value
      shouldn't be treated as a distinguisher for them. ip_tunnel_key_match exists for
      cases when we want to compare two ip_tunnel_parms' i_keys.
      Example bug:
      ip link add type vti ikey 1 local remote
      ip link add type vti ikey 2 local remote
      spawned two tunnels, although it doesn't make sense.
      Signed-off-by: default avatarDmitry Popov <[email protected]>
      Signed-off-by: default avatarDavid S. Miller <[email protected]>
    • Dmitry Popov's avatar
      ip_vti: Fix 'ip tunnel add' with 'key' parameters · 7c8e6b9c
      Dmitry Popov authored
      ip tunnel add remote local mode vti ikey 1 okey 2
      translates to p->iflags = VTI_ISVTI|GRE_KEY and p->i_key = 1, but GRE_KEY !=
      TUNNEL_KEY, so ip_tunnel_ioctl would set i_key to 0 (same story with o_key)
      making us unable to create vti tunnels with [io]key via ip tunnel.
      We cannot simply translate GRE_KEY to TUNNEL_KEY (as GRE module does) because
      vti_tunnels with same local/remote addresses but different ikeys will be treated
      as different then. So, imo the best option here is to move p->i_flags & *_KEY
      check for vti tunnels from ip_tunnel.c to ip_vti.c and to think about [io]_mark
      field for ip_tunnel_parm in the future.
      Signed-off-by: default avatarDmitry Popov <[email protected]>
      Signed-off-by: default avatarDavid S. Miller <[email protected]>
  35. 06 Jun, 2014 1 commit
  36. 21 May, 2014 1 commit