Commit fc7392aa authored by Elias Vanderstuyft's avatar Elias Vanderstuyft Committed by Dmitry Torokhov
Browse files

Input: don't modify the id of ioctl-provided ff effect on upload failure

If a new (id == -1) ff effect was uploaded from userspace,
ff-core.c::input_ff_upload() will have assigned a positive number to the
new effect id.  Currently, evdev.c::evdev_do_ioctl() will save this new id
to userspace, regardless of whether the upload succeeded or not.

On upload failure, this can be confusing because the dev->ff->effects[]
array will not contain an element at the index of that new effect id.

This patch fixes this by leaving the id unchanged after upload fails.

Note: Unfortunately applications should still expect changed effect id for
quite some time.

This has been discussed on:

("ff-core effect id handling in case of a failed effect upload")
Suggested-by: default avatarDmitry Torokhov <>
Signed-off-by: Elias Vanderstuyft's avatarElias Vanderstuyft <>
Signed-off-by: default avatarDmitry Torokhov <>
parent 8a0435d9
......@@ -954,11 +954,13 @@ static long evdev_do_ioctl(struct file *file, unsigned int cmd,
return -EFAULT;
error = input_ff_upload(dev, &effect, file);
if (error)
return error;
if (put_user(, &(((struct ff_effect __user *)p)->id)))
return -EFAULT;
return error;
return 0;
/* Multi-number variable-length handlers */
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment