Commit ebde1ca5 authored by Nicholas Bellinger's avatar Nicholas Bellinger

target: Fix TAS handling for multi-session se_node_acls

This patch fixes a bug in TMR task aborted status (TAS)
handling when multiple sessions are connected to the
same target WWPN endpoint and se_node_acl descriptor,
resulting in TASK_ABORTED status to not be generated
for aborted se_cmds on the remote port.

This is due to core_tmr_handle_tas_abort() incorrectly
comparing se_node_acl instead of se_session, for which
the multi-session case is expected to be sharing the
same se_node_acl.

Instead, go ahead and update core_tmr_handle_tas_abort()
to compare tmr_sess + cmd->se_sess in order to determine
if the LUN_RESET was received on a different I_T nexus,
and TASK_ABORTED status response needs to be generated.
Reviewed-by: default avatarChristoph Hellwig <[email protected]>
Cc: Quinn Tran <[email protected]>
Cc: Himanshu Madhani <[email protected]>
Cc: Sagi Grimberg <[email protected]>
Cc: Hannes Reinecke <[email protected]>
Cc: Andy Grover <[email protected]>
Cc: Mike Christie <[email protected]>
Cc: [email protected] # 3.10+
Signed-off-by: default avatarNicholas Bellinger <[email protected]>
parent a6d9bb1c
......@@ -76,7 +76,7 @@ void core_tmr_release_req(struct se_tmr_req *tmr)
static void core_tmr_handle_tas_abort(
struct se_node_acl *tmr_nacl,
struct se_session *tmr_sess,
struct se_cmd *cmd,
int tas)
......@@ -84,7 +84,7 @@ static void core_tmr_handle_tas_abort(
* TASK ABORTED status (TAS) bit support
if ((tmr_nacl && (tmr_nacl != cmd->se_sess->se_node_acl)) && tas) {
if (tmr_sess && tmr_sess != cmd->se_sess && tas) {
remove = false;
......@@ -273,7 +273,7 @@ static void core_tmr_drain_tmr_list(
static void core_tmr_drain_state_list(
struct se_device *dev,
struct se_cmd *prout_cmd,
struct se_node_acl *tmr_nacl,
struct se_session *tmr_sess,
int tas,
struct list_head *preempt_and_abort_list)
......@@ -364,7 +364,7 @@ static void core_tmr_drain_state_list(
core_tmr_handle_tas_abort(tmr_nacl, cmd, tas);
core_tmr_handle_tas_abort(tmr_sess, cmd, tas);
......@@ -377,6 +377,7 @@ int core_tmr_lun_reset(
struct se_node_acl *tmr_nacl = NULL;
struct se_portal_group *tmr_tpg = NULL;
struct se_session *tmr_sess = NULL;
int tas;
* TASK_ABORTED status bit, this is configurable via ConfigFS
......@@ -395,8 +396,9 @@ int core_tmr_lun_reset(
* or struct se_device passthrough..
if (tmr && tmr->task_cmd && tmr->task_cmd->se_sess) {
tmr_nacl = tmr->task_cmd->se_sess->se_node_acl;
tmr_tpg = tmr->task_cmd->se_sess->se_tpg;
tmr_sess = tmr->task_cmd->se_sess;
tmr_nacl = tmr_sess->se_node_acl;
tmr_tpg = tmr_sess->se_tpg;
if (tmr_nacl && tmr_tpg) {
pr_debug("LUN_RESET: TMR caller fabric: %s"
" initiator port %s\n",
......@@ -409,7 +411,7 @@ int core_tmr_lun_reset(
dev->transport->name, tas);
core_tmr_drain_tmr_list(dev, tmr, preempt_and_abort_list);
core_tmr_drain_state_list(dev, prout_cmd, tmr_nacl, tas,
core_tmr_drain_state_list(dev, prout_cmd, tmr_sess, tas,
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment