Commit e086846a authored by Filipe Manana's avatar Filipe Manana Committed by Greg Kroah-Hartman

btrfs: fix removal of raid[56|1c34} incompat flags after removing block group

commit d8e6fd5c upstream.

We are incorrectly dropping the raid56 and raid1c34 incompat flags when
there are still raid56 and raid1c34 block groups, not when we do not any
of those anymore. The logic just got unintentionally broken after adding
the support for the raid1c34 modes.

Fix this by clear the flags only if we do not have block groups with the
respective profiles.

Fixes: 9c907446 ("btrfs: drop incompat bit for raid1c34 after last block group is gone")
Signed-off-by: default avatarFilipe Manana <[email protected]>
Reviewed-by: default avatarDavid Sterba <[email protected]>
Signed-off-by: default avatarDavid Sterba <[email protected]>
Signed-off-by: default avatarGreg Kroah-Hartman <[email protected]>
parent c325c96b
......@@ -849,9 +849,9 @@ static void clear_incompat_bg_bits(struct btrfs_fs_info *fs_info, u64 flags)
found_raid1c34 = true;
up_read(&sinfo->groups_sem);
}
if (found_raid56)
if (!found_raid56)
btrfs_clear_fs_incompat(fs_info, RAID56);
if (found_raid1c34)
if (!found_raid1c34)
btrfs_clear_fs_incompat(fs_info, RAID1C34);
}
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment