Commit dd53d830 authored by Wenwen Wang's avatar Wenwen Wang Committed by Greg Kroah-Hartman

infiniband: hfi1: fix memory leaks

[ Upstream commit 2323d7ba ]

In fault_opcodes_write(), 'data' is allocated through kcalloc(). However,
it is not deallocated in the following execution if an error occurs,
leading to memory leaks. To fix this issue, introduce the 'free_data' label
to free 'data' before returning the error.
Signed-off-by: Wenwen Wang's avatarWenwen Wang <>
Reviewed-by: default avatarLeon Romanovsky <>
Acked-by: default avatarDennis Dalessandro <>
Link: Doug Ledford's avatarDoug Ledford <>
Signed-off-by: default avatarSasha Levin <>
parent bcb32116
......@@ -141,12 +141,14 @@ static ssize_t fault_opcodes_write(struct file *file, const char __user *buf,
if (!data)
return -ENOMEM;
copy = min(len, datalen - 1);
if (copy_from_user(data, buf, copy))
return -EFAULT;
if (copy_from_user(data, buf, copy)) {
ret = -EFAULT;
goto free_data;
ret = debugfs_file_get(file->f_path.dentry);
if (unlikely(ret))
return ret;
goto free_data;
ptr = data;
token = ptr;
for (ptr = data; *ptr; ptr = end + 1, token = ptr) {
......@@ -195,6 +197,7 @@ static ssize_t fault_opcodes_write(struct file *file, const char __user *buf,
ret = len;
return ret;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment