Commit bcb32116 authored by Wenwen Wang's avatar Wenwen Wang Committed by Greg Kroah-Hartman

infiniband: hfi1: fix a memory leak bug

[ Upstream commit b08afa06 ]

In fault_opcodes_read(), 'data' is not deallocated if debugfs_file_get()
fails, leading to a memory leak. To fix this bug, introduce the 'free_data'
label to free 'data' before returning the error.
Signed-off-by: Wenwen Wang's avatarWenwen Wang <>
Reviewed-by: default avatarLeon Romanovsky <>
Acked-by: default avatarDennis Dalessandro <>
Link: Doug Ledford's avatarDoug Ledford <>
Signed-off-by: default avatarSasha Levin <>
parent 1e931496
......@@ -214,7 +214,7 @@ static ssize_t fault_opcodes_read(struct file *file, char __user *buf,
return -ENOMEM;
ret = debugfs_file_get(file->f_path.dentry);
if (unlikely(ret))
return ret;
goto free_data;
bit = find_first_bit(fault->opcodes, bitsize);
while (bit < bitsize) {
zero = find_next_zero_bit(fault->opcodes, bitsize, bit);
......@@ -232,6 +232,7 @@ static ssize_t fault_opcodes_read(struct file *file, char __user *buf,
data[size - 1] = '\n';
data[size] = '\0';
ret = simple_read_from_buffer(buf, len, pos, data, size);
return ret;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment