Commit a39ee449 authored by MST's avatar MST Committed by David S. Miller
Browse files

vhost: validate vhost_get_vq_desc return value

vhost fails to validate negative error code
from vhost_get_vq_desc causing
a crash: we are using -EFAULT which is 0xfffffff2
as vector size, which exceeds the allocated size.

The code in question was introduced in commit

    vhost-net: mergeable buffers support

Signed-off-by: MST's avatarMichael S. Tsirkin <>
Signed-off-by: default avatarDavid S. Miller <>
parent d8316f39
......@@ -505,9 +505,13 @@ static int get_rx_bufs(struct vhost_virtqueue *vq,
goto err;
d = vhost_get_vq_desc(vq->dev, vq, vq->iov + seg,
r = vhost_get_vq_desc(vq->dev, vq, vq->iov + seg,
ARRAY_SIZE(vq->iov) - seg, &out,
&in, log, log_num);
if (unlikely(r < 0))
goto err;
d = r;
if (d == vq->num) {
r = 0;
goto err;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment