Commit 83d5f018 authored by Eric Sandeen's avatar Eric Sandeen Committed by Dave Chinner

xfs: cancel failed transaction in xfs_fs_commit_blocks()

If xfs_trans_reserve fails we don't cancel the transaction,
and we'll leak the allocated transaction pointer.

Spotted by Coverity.
Signed-off-by: default avatarEric Sandeen <[email protected]>
Reviewed-by: default avatarChristoph Hellwig <[email protected]>
Signed-off-by: default avatarDave Chinner <[email protected]>
parent fc921566
...@@ -300,8 +300,10 @@ xfs_fs_commit_blocks( ...@@ -300,8 +300,10 @@ xfs_fs_commit_blocks(
tp = xfs_trans_alloc(mp, XFS_TRANS_SETATTR_NOT_SIZE); tp = xfs_trans_alloc(mp, XFS_TRANS_SETATTR_NOT_SIZE);
error = xfs_trans_reserve(tp, &M_RES(mp)->tr_ichange, 0, 0); error = xfs_trans_reserve(tp, &M_RES(mp)->tr_ichange, 0, 0);
if (error) if (error) {
xfs_trans_cancel(tp, 0);
goto out_drop_iolock; goto out_drop_iolock;
xfs_ilock(ip, XFS_ILOCK_EXCL); xfs_ilock(ip, XFS_ILOCK_EXCL);
xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL); xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL);
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment