Commit 72c60722 authored by Zenghui Yu's avatar Zenghui Yu Committed by Greg Kroah-Hartman

irqchip/gic-v3-its: Reference to its_invall_cmd descriptor when building INVALL

[ Upstream commit 10794522 ]

It looks like an obvious mistake to use its_mapc_cmd descriptor when
building the INVALL command block. It so far worked by luck because
both its_mapc_cmd.col and its_invall_cmd.col sit at the same offset of
the ITS command descriptor, but we should not rely on it.

Fixes: cc2d3216 ("irqchip: GICv3: ITS command queue")
Signed-off-by: default avatarZenghui Yu <[email protected]>
Signed-off-by: default avatarMarc Zyngier <[email protected]org>
Link: https://lore.kernel.org/r/[email protected]Signed-off-by: default avatarSasha Levin <[email protected]>
parent 46991b18
......@@ -598,7 +598,7 @@ static struct its_collection *its_build_invall_cmd(struct its_node *its,
struct its_cmd_desc *desc)
{
its_encode_cmd(cmd, GITS_CMD_INVALL);
its_encode_collection(cmd, desc->its_mapc_cmd.col->col_id);
its_encode_collection(cmd, desc->its_invall_cmd.col->col_id);
its_fixup_cmd(cmd);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment