Commit 409186c5 authored by Filipe Manana's avatar Filipe Manana Committed by Greg Kroah-Hartman

btrfs: fix log context list corruption after rename whiteout error

commit 236ebc20d9afc5e9ff52f3cf3f365a91583aac10 upstream.

During a rename whiteout, if btrfs_whiteout_for_rename() returns an error
we can end up returning from btrfs_rename() with the log context object
still in the root's log context list - this happens if 'sync_log' was
set to true before we called btrfs_whiteout_for_rename() and it is
dangerous because we end up with a corrupt linked list (root->log_ctxs)
as the log context object was allocated on the stack.

After btrfs_rename() returns, any task that is running btrfs_sync_log()
concurrently can end up crashing because that linked list is traversed by
btrfs_sync_log() (through btrfs_remove_all_log_ctxs()). That results in
the same issue that commit e6c61710 ("Btrfs: fix log context list
corruption after rename exchange operation") fixed.

Fixes: d4682ba0 ("Btrfs: sync log after logging new name")
CC: [email protected] # 4.19+
Signed-off-by: default avatarFilipe Manana <[email protected]>
Signed-off-by: default avatarDavid Sterba <[email protected]>
Signed-off-by: default avatarGreg Kroah-Hartman <[email protected]>
parent 6b3917c5
......@@ -10159,6 +10159,10 @@ static int btrfs_rename(struct inode *old_dir, struct dentry *old_dentry,
ret = btrfs_sync_log(trans, BTRFS_I(old_inode)->root, &ctx);
if (ret)
commit_transaction = true;
} else if (sync_log) {
mutex_lock(&root->log_mutex);
list_del(&ctx.list);
mutex_unlock(&root->log_mutex);
}
if (commit_transaction) {
ret = btrfs_commit_transaction(trans);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment