Commit 19105f42 authored by Josh Poimboeuf's avatar Josh Poimboeuf Committed by Alexandre Belloni

rtc: ds1685: actually spin forever in poweroff path

objtool reports the following warning:

  drivers/rtc/rtc-ds1685.o: warning: objtool: ds1685_rtc_poweroff() falls through to next function ds1685_rtc_work_queue()

Similar to commit 361c6ed6 ("rtc: ds1685: actually spin forever in
poweroff error path"), there's another unreachable() annotation which is
actually reachable, which we missed the first time.

Actually spin forever to be consistent with the comment and to make the
unreachable() annotation guaranteed to be unreachable.
Reported-by: default avatarkbuild test robot <[email protected]>
Signed-off-by: default avatarJosh Poimboeuf <[email protected]>
Signed-off-by: default avatarAlexandre Belloni <[email protected]>
parent 6406d96e
......@@ -2211,6 +2211,7 @@ ds1685_rtc_poweroff(struct platform_device *pdev)
(ctrl4a | RTC_CTRL_4A_PAB));
/* Spin ... we do not switch back to bank0. */
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment