• Nicolas Dichtel's avatar
    vti: don't allow to add the same tunnel twice · 8d89dcdf
    Nicolas Dichtel authored
    Before the patch, it was possible to add two times the same tunnel:
    ip l a vti1 type vti remote local key 41
    ip l a vti2 type vti remote local key 41
    It was possible, because ip_tunnel_newlink() calls ip_tunnel_find() with the
    argument dev->type, which was set only later (when calling ndo_init handler
    in register_netdevice()). Let's set this type in the setup handler, which is
    called before newlink handler.
    Introduced by commit b9959fd3 ("vti: switch to new ip tunnel code").
    CC: Cong Wang <amwang@redhat.com>
    CC: Steffen Klassert <steffen.klassert@secunet.com>
    Signed-off-by: default avatarNicolas Dichtel <nicolas.dichtel@6wind.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
ip_vti.c 14 KB