• Christoph Hellwig's avatar
    scsi: don't set tagging state from scsi_adjust_queue_depth · c8b09f6f
    Christoph Hellwig authored
    Remove the tagged argument from scsi_adjust_queue_depth, and just let it
    handle the queue depth.  For most drivers those two are fairly separate,
    given that most modern drivers don't care about the SCSI "tagged" status
    of a command at all, and many old drivers allow queuing of multiple
    untagged commands in the driver.
    
    Instead we start out with the ->simple_tags flag set before calling
    ->slave_configure, which is how all drivers actually looking at
    ->simple_tags except for one worke anyway.  The one other case looks
    broken, but I've kept the behavior as-is for now.
    
    Except for that we only change ->simple_tags from the ->change_queue_type,
    and when rejecting a tag message in a single driver, so keeping this
    churn out of scsi_adjust_queue_depth is a clear win.
    
    Now that the usage of scsi_adjust_queue_depth is more obvious we can
    also remove all the trivial instances in ->slave_alloc or ->slave_configure
    that just set it to the cmd_per_lun default.
    Signed-off-by: default avatarChristoph Hellwig <[email protected]de>
    Reviewed-by: default avatarMike Christie <[email protected]>
    Reviewed-by: Hannes Reinecke's avatarHannes Reinecke <[email protected]>
    Reviewed-by: Martin K. Petersen's avatarMartin K. Petersen <[email protected]>
    c8b09f6f
3w-xxxx.c 83.9 KB