Skip to content

Added support for detecting source files in the user's download directory

Benjamin Winger requested to merge bmwinger/portmod:user_download_dir into master

As suggested in #169 (closed), I've added support for detecting source files in the ~/Downloads directory. Given that we're dealing with user directories rather than portmod directories, I've also delayed any moving of such files until after the user has accepted the "would you like to continue" prompt (also to avoid the informative "Moving x -> y" message showing up in odd places).

Documentation should be updated, both to make the fact that you can put downloads in the ~/Downloads directory more discoverable, as well as to document the DOWNLOADS fallback environment variable which defines another place the code will check if it exists (e.g. if your Downloads directory is not in ~/Downloads (e.g. possibly on windows. I decided against the "proper" way of detecting the download directory, given that it requires a bunch of registry code which is far more trouble than it's worth. That being said, Wine at the very least sets up a Downloads directory that ~/Downloads resolves to).

Merge request reports