Skip to content
GitLab

specVerifier use ValueError and manager soln tab fixes

Merged Colin Macdonald requested to merge valueerror into main

We removed numberToPrename, throwing a NotImplementedError. This was reasonable but:

  • the docs for specVerifier do not mention the new behaviour, only ValueError
  • various bits of code, e.g., in API for put_spec, only expect ValueError and thus fail with 500 instead of something more graceful.
  • usually NotImplementedError is for code we haven't written yet.

There is a deprecation warning mechanism but we already dropped it (and we're not at 1.0.0 yet).

I think it might be easier to just throw ValueError: that is done here.

Also: manager's SolnTab was enable/disabled differently than the others: fix that and reorg code a little for future changes.