Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • P plom
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 597
    • Issues 597
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

GitLab 15.0 has launched! Please visit Breaking changes in 15.0 and 15.0 Removals to see which breaking changes may impact your workflow.

  • plom
  • plom
  • Merge requests
  • !1235

SimpleMessage -> SimpleQuestion, with parents

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Colin Macdonald requested to merge parent_dialog into main Jan 21, 2022
  • Overview 2
  • Commits 6
  • Pipelines 1
  • Changes 9

Continuing my quest for modal dialogs cleanups. This time its "SimpleMessage".

  • it always annoyed me b/c it asks a question So I have renamed it to SimpleQuestion.

  • It now requires you do specify the parent. Can be None if you don't know one or don't know (rare, currently the ctrl-C handler).


In some cases I used the subclass WarningQuestion which has a slightly more panicky warning icon instead of just a question icon.

It's alway possible to provide the question as a separate arg:

  SimpleQuestion(parent, "On no!  blah blah * 100", "Should we continue?",  details=...)

In some cases, I changed the messages to be phrased like that (its not required).

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: parent_dialog