Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    • Menu
    Projects Groups Snippets
  • Get a free trial
  • Sign up
  • Login
  • Sign in / Register
  • P plom
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 598
    • Issues 598
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

GitLab 15.0 has launched! Please visit Breaking changes in 15.0 and 15.0 Removals to see which breaking changes may impact your workflow.

  • plom
  • plom
  • Merge requests
  • !1233

Another hack at top of page test-group-page signatures

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Andrew Rechnitzer requested to merge recidivist into main Jan 20, 2022
  • Overview 21
  • Commits 3
  • Pipelines 3
  • Changes 4

Changing the code stamped onto the top of pages by plom (for test-pages). Is now

1234.ggg pp

where ggg is the group to which the page belongs 'id' or 'dnm' or 'q7' (say), and pp is the page number 'p3' (say)

To make this work we have to pass around a "page to group" dictionary that maps a page number to the name of the group to which it belongs.

Needs

  • decision = is this format good enough
  • decision = what do we do for user-modified labels for questions (how do we handle weird question-names?) Defer to #1886?
  • decision = do we move the page_to_group function into the spec-verifier code (probably we should)
  • decision = what else in this list.
  • changelog entry

Then - mergin.

Edited Jan 21, 2022 by Colin Macdonald
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: recidivist