Loading
Commits on Source 3
-
Matt Cockayne authored
-
Matt Cockayne authored
Found by a documentation audit against the source, run after a sibling audit of the forge module found twenty drift findings. Four shapes repeat across every adapter, and are fixed the same way in each: - ReleaseSource.Host appeared twice in the README and once in NewReleaseProvider's godoc. The type does not exist; the field is Endpoint.Host. - key.go's UploadKey godoc pointed at [Settings.Auth]. There is no Auth field, so pkg.go.dev rendered a link to nothing. It is Settings.Credential. - discovery.go and issues.go cited specs by a docs/development/specs/<date>.md path. forge moved every spec to the wiki on 2026-08-06 and those paths have not resolved since; they now cite the wiki pages by number. The fourth is the one worth reading. SettingsFromConfig's godoc opened with: cfg is the ALREADY sub-scoped section (the factory passes forge.SubConfig(cfg, section)) and closed, in the same comment, with: cfg is the ROOT configuration, not a pre-scoped subtree Both, in the godoc of one exported function, about the parameter that fails SILENTLY when a caller gets it wrong. Following the first sentence pre-scopes the config and the adapter then looks for gitea.gitea.auth.value, finds nothing, and resolves no credential and no URL — with no error to say why. The closing paragraph was added when the Endpoint cut landed and the opening one was never removed, so the comment has contradicted itself since. The stale paragraph is deleted. The closing one also regains the blank line it lost when it was appended, so godoc renders it as its own paragraph rather than running it into the sentence above. -
Matt Cockayne authored