This project is mirrored from https://github.com/pgbackrest/pgbackrest. Pull mirroring updated .
  1. 05 Mar, 2021 2 commits
  2. 04 Mar, 2021 1 commit
  3. 03 Mar, 2021 1 commit
    • David Steele's avatar
      Make --repo optional for remaining commands except stanza-delete. · 95063f68
      David Steele authored
      Some commands (repo-*, verify) still required the --repo option but it makes sense to give them the same treatment as backup and simply use the first repo when one is not specified.
      
      This leaves stanza-delete as the only remaining command that requires --repo. This is by design to enhance safe usage.
      95063f68
  4. 02 Mar, 2021 2 commits
    • David Steele's avatar
      Update to help.auto.c missed in d1aa765a. · cb26e8c7
      David Steele authored
      cb26e8c7
    • David Steele's avatar
      Consolidate less commonly used repository storage options. · d1aa765a
      David Steele authored
      The following options are renamed as specified:
      
      repo1-azure-ca-file -> repo1-storage-ca-file
      repo1-azure-ca-path -> repo1-storage-ca-path
      repo1-azure-host -> repo1-storage-host
      repo1-azure-port -> repo1-storage-port
      repo1-azure-verify-tls -> repo1-storage-verify-tls
      repo1-s3-ca-file -> repo1-storage-ca-file
      repo1-s3-ca-path -> repo1-storage-ca-path
      repo1-s3-host -> repo1-storage-host
      repo1-s3-port -> repo1-storage-port
      repo1-s3-verify-tls -> repo1-storage-verify-tls
      
      The old option names (e.g. repo1-s3-port) will continue to work for repo1, but repo2, etc. will require the new names.
      d1aa765a
  5. 01 Mar, 2021 1 commit
  6. 28 Feb, 2021 6 commits
    • David Steele's avatar
      Add storageInfoLevelType. · 1d77db31
      David Steele authored
      This allows the removal of the callback in the S3/Azure storage drivers that existed only to parse the size/time information.
      
      The extra callback was required because not all callers of storage*ListInternal() want size/time info, so it was wasteful to add it to storage*ListInternal(). Now those callers can request type info only.
      1d77db31
    • David Steele's avatar
      Make remote storage objects writeable. · 54c4eb0c
      David Steele authored
      This wasn't exposed before because the remote protocol directly uses the storage driver, which bypasses the writeable checks.
      
      However, the upcoming GCS driver explicitly requests write permissions so remote operations fail when a write is required.
      
      It would be far better if the remote itself was marked as writeable but that will require much more work.
      54c4eb0c
    • David Steele's avatar
      Fix comments. · 46922ff2
      David Steele authored
      46922ff2
    • David Steele's avatar
      Suppress implicit-fallthrough warning. · 0766b7e5
      David Steele authored
      Warning on missing breaks in switch statements works great until it is intended.
      
      Suppressing on a case by case basis varies by compiler and version so is not very practical. Our tests should be sufficient to the task of finding missing breaks.
      0766b7e5
    • David Steele's avatar
      Make S3/Azure file missing error messages match Posix. · a1341b4a
      David Steele authored
      The S3 driver was missed when the constants were added and then Azure was copied from S3.
      a1341b4a
    • David Steele's avatar
      Add missing linefeed. · 3fb6da64
      David Steele authored
      3fb6da64
  7. 26 Feb, 2021 3 commits
  8. 25 Feb, 2021 1 commit
    • Michael Schout's avatar
      Allow custom config-path default with ./configure --with-configdir. · 9243962b
      Michael Schout authored
      Add --with-confdir=DIR option to configure, which can be used to override the default configuration directory of /etc/pgbackrest.
      
      Probably in the future it would be better to just leverage ${sysconfdir} which is based on prefix, but since previously the config directory was hard coded to /etc/pgbackrest, we retain that default value by not relying on sysconfdir for now.
      9243962b
  9. 24 Feb, 2021 2 commits
  10. 23 Feb, 2021 6 commits
  11. 20 Feb, 2021 2 commits
  12. 19 Feb, 2021 9 commits
  13. 18 Feb, 2021 1 commit
    • David Steele's avatar
      Fix option warnings breaking async archive-get/archive-push. · 3837e61a
      David Steele authored
      Option warnings will cause the async process to fail because a warning is logged but stdout is closed so the process aborts.
      
      This bug has existed for quite some time, but it was made worse by abb8ebe5 because now the async role can have different valid options than the default role. Previously at least a warning would be emitted before the async process died.
      
      Fix this by only allowing warnings for the default role. Warnings were already suppressed for local and remote roles so the logic already exists.
      3837e61a
  14. 16 Feb, 2021 1 commit
    • David Steele's avatar
      Fix tests that ensure log levels are not set for local/remote roles. · d7befd41
      David Steele authored
      These tests were broken because they were being gated by resetLogLevel. So they were not setting the log levels, but not because of the role setting. Because resetLogLevel was being checked last coverage testing indicated that the tests were working.
      
      Fix the resetLogLevel parameter in the tests and move resetLogLevel to be tested first so coverage reporting works as expected. This isn't perfect but it is an improvement.
      d7befd41
  15. 12 Feb, 2021 1 commit
    • David Steele's avatar
      Fix stack overflow in cipher passphrase generation. · d29855bd
      David Steele authored
      The destination buffer on the stack was not large enough to contain the zero-terminating character.
      
      Increase the buffer size and add an assertion to prevent regressions.
      
      Found on arm64 running musl libc. Other architectures and glibc do not seem to be affected though it is clearly a bug.
      d29855bd
  16. 10 Feb, 2021 1 commit