Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • P pg_proctab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • pg_proctab
  • pg_proctab
  • Merge requests
  • !3

Use PG_VERSION_NUM to build with the right query

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jeremy Schneider requested to merge ardentperf/pg_proctab:pg10compat2 into master May 02, 2020
  • Overview 3
  • Commits 1
  • Pipelines 0
  • Changes 2

The IEEE-compliant "expr" command does not support float comparison, and thus the version comparisons in the Makefile were using string comparison. This worked fine through PostgreSQL version 9.6 but no longer worked when PostgreSQL 10 was released.

This change uses PG_VERSION_NUM directly in the C code to do the comparison, and removes the logic from the Makefile.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: pg10compat2