1. 16 Oct, 2015 1 commit
  2. 20 Aug, 2014 1 commit
  3. 17 Jan, 2012 1 commit
    • Jeff King's avatar
      credential-cache: ignore "connection refused" errors · 35a71f14
      Jeff King authored
      The credential-cache helper will try to connect to its
      daemon over a unix socket. Originally, a failure to do so
      was silently ignored, and we would either give up (if
      performing a "get" or "erase" operation), or spawn a new
      daemon (for a "store" operation).
      
      But since 8ec6c8d7, we try to report more errors. We detect a
      missing daemon by checking for ENOENT on our connection
      attempt.  If the daemon is missing, we continue as before
      (giving up or spawning a new daemon). For any other error,
      we die and report the problem.
      
      However, checking for ENOENT is not sufficient for a missing
      daemon. We might also get ECONNREFUSED if a dead daemon
      process left a stale socket. This generally shouldn't
      happen, as the daemon cleans up after itself, but the daemon
      may not always be given a chance to do so (e.g., power loss,
      "kill -9").
      
      The resulting state is annoying not just because the helper
      outputs an extra useless message, but because it actually
      blocks the helper from spawning a new daemon to replace the
      stale socket.
      
      Fix it by checking for ECONNREFUSED.
      Signed-off-by: default avatarJeff King <peff@peff.net>
      Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
      35a71f14
  4. 10 Jan, 2012 1 commit
    • Jeff King's avatar
      credential-cache: report more daemon connection errors · 8ec6c8d7
      Jeff King authored
      Originally, this code remained relatively silent when we
      failed to connect to the cache. The idea was that it was
      simply a cache, and we didn't want to bother the user with
      temporary failures (the worst case is that we would simply
      ask their password again).
      
      However, if you have a configuration failure or other
      problem, it is helpful for the daemon to report those
      problems. Git will happily ignore the failed error code, but
      the extra information to stderr can help the user diagnose
      the problem.
      Signed-off-by: default avatarJeff King <peff@peff.net>
      Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
      8ec6c8d7
  5. 08 Jan, 2012 1 commit
  6. 12 Dec, 2011 1 commit
    • Jeff King's avatar
      credentials: add "cache" helper · e2770979
      Jeff King authored
      If you access repositories over smart-http using http
      authentication, then it can be annoying to have git ask you
      for your password repeatedly. We cache credentials in
      memory, of course, but git is composed of many small
      programs. Having to input your password for each one can be
      frustrating.
      
      This patch introduces a credential helper that will cache
      passwords in memory for a short period of time.
      Signed-off-by: default avatarJeff King <peff@peff.net>
      Signed-off-by: default avatarJunio C Hamano <gitster@pobox.com>
      e2770979